Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8234484: Add ability to configure third port for remote JMX #213

Closed
wants to merge 1 commit into from

Conversation

vyommani
Copy link

@vyommani vyommani commented Dec 16, 2022

Reviewed-by: ksrini
Backport-of: f129cc43283a18cb5afdd1416b09691a636a7758


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8234484: Add ability to configure third port for remote JMX

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/213/head:pull/213
$ git checkout pull/213

Update a local copy of the PR:
$ git checkout pull/213
$ git pull https://git.openjdk.org/jdk8u-dev pull/213/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 213

View PR using the GUI difftool:
$ git pr show -t 213

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/213.diff

Reviewed-by: ksrini
Backport-of: f129cc43283a18cb5afdd1416b09691a636a7758
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2022

👋 Welcome back vtewari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f129cc43283a18cb5afdd1416b09691a636a7758 8234484: Add ability to configure third port for remote JMX Dec 16, 2022
@openjdk
Copy link

openjdk bot commented Dec 16, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Dec 16, 2022
@openjdk
Copy link

openjdk bot commented Dec 16, 2022

⚠️ @vyommani a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 0662db27bf72d15b2fdd7ed21ea675d40531aef5
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 16, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 16, 2022

Webrevs

@vyommani
Copy link
Author

I tested locally on Linux/Windows Tier1 & Tier2 and all test pass.

Copy link
Member

@kusrinivasan kusrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good the backport is identical except for the jdk8 layout differences.

@openjdk
Copy link

openjdk bot commented Dec 16, 2022

@vyommani This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8234484: Add ability to configure third port for remote JMX

Reviewed-by: ksrini

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 06546d7: 8284102: [TESTBUG] [11u] Retroactively add regression test for JDK-8272124
  • 9f76da9: 8284756: [11u] Remove unused isUseContainerSupport in CgroupV1Subsystem
  • d6101df: 8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards
  • 99ff02e: 8266391: Replace use of reflection in jdk.internal.platform.Metrics

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kusrinivasan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 16, 2022
@vyommani
Copy link
Author

/integrate

@kusrinivasan
Copy link
Member

/sponsor

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 19, 2022
@openjdk
Copy link

openjdk bot commented Dec 19, 2022

@vyommani
Your change (at version c6f64f7) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Dec 19, 2022

Going to push as commit 78cdc41.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 06546d7: 8284102: [TESTBUG] [11u] Retroactively add regression test for JDK-8272124
  • 9f76da9: 8284756: [11u] Remove unused isUseContainerSupport in CgroupV1Subsystem
  • d6101df: 8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards
  • 99ff02e: 8266391: Replace use of reflection in jdk.internal.platform.Metrics

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 19, 2022
@openjdk openjdk bot closed this Dec 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 19, 2022
@openjdk
Copy link

openjdk bot commented Dec 19, 2022

@kusrinivasan @vyommani Pushed as commit 78cdc41.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants