-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8234484: Add ability to configure third port for remote JMX #213
Conversation
Reviewed-by: ksrini Backport-of: f129cc43283a18cb5afdd1416b09691a636a7758
👋 Welcome back vtewari! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
To avoid this situation, create a new branch for your changes and reset the
Then proceed to create a new pull request with |
I tested locally on Linux/Windows Tier1 & Tier2 and all test pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good the backport is identical except for the jdk8 layout differences.
@vyommani This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kusrinivasan) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Going to push as commit 78cdc41.
Your commit was automatically rebased without conflicts. |
@kusrinivasan @vyommani Pushed as commit 78cdc41. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Reviewed-by: ksrini
Backport-of: f129cc43283a18cb5afdd1416b09691a636a7758
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/213/head:pull/213
$ git checkout pull/213
Update a local copy of the PR:
$ git checkout pull/213
$ git pull https://git.openjdk.org/jdk8u-dev pull/213/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 213
View PR using the GUI difftool:
$ git pr show -t 213
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/213.diff