New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist #215
8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist #215
Conversation
|
Webrevs
|
@kurashige23 Please change the PR title to |
This backport pull request has now been updated with issue from the original commit. |
@jerboaa I'm sorry for some mistakes. I fixed PR title and enabled GHA testing. Is that all right? |
Clean backport (only path changes). Marking as such. /clean |
@jerboaa This backport pull request is now marked as clean |
@kurashige23 Please proceed with applying for JDK 8u backports approval as described in |
|
@kurashige23 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change.
|
@jerboaa Thank you for giving the link. |
Yes. I've added them for you and approved as it's a test-only bug. Feel free to integrate. |
/integrate |
@kurashige23 |
/sponsor |
Going to push as commit b4a745d. |
@jerboaa @kurashige23 Pushed as commit b4a745d. |
Hi all,
I'd like to backport this to jdk8u-dev.
It fixes a test failure caused by cgroups virtual files (nr_periods etc) not existing in some circumstances.
Thanks.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/215/head:pull/215
$ git checkout pull/215
Update a local copy of the PR:
$ git checkout pull/215
$ git pull https://git.openjdk.org/jdk8u-dev pull/215/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 215
View PR using the GUI difftool:
$ git pr show -t 215
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/215.diff