Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete #219

Closed
wants to merge 1 commit into from

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Dec 20, 2022

Clean backport. Only path differences.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/219/head:pull/219
$ git checkout pull/219

Update a local copy of the PR:
$ git checkout pull/219
$ git pull https://git.openjdk.org/jdk8u-dev pull/219/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 219

View PR using the GUI difftool:
$ git pr show -t 219

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/219.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2022

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into pr/218 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8d28734ede0ed3922c92451a172d1fa676e484e9 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete Dec 20, 2022
@openjdk
Copy link

openjdk bot commented Dec 20, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 20, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 20, 2022

Webrevs

@jerboaa
Copy link
Contributor Author

jerboaa commented Dec 21, 2022

Clean backport. Marking as such.

/clean

@openjdk openjdk bot added the clean label Dec 21, 2022
@openjdk
Copy link

openjdk bot commented Dec 21, 2022

@jerboaa This backport pull request is now marked as clean

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 18, 2023

@jerboaa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@jerboaa
Copy link
Contributor Author

jerboaa commented Jan 18, 2023

Give me some time please, bot.

@openjdk
Copy link

openjdk bot commented Jan 27, 2023

@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@jerboaa
Copy link
Contributor Author

jerboaa commented Jan 27, 2023

Windows GHA test failed due to #240 (unrelated).

gnu-andrew
gnu-andrew previously approved these changes Jan 27, 2023
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed clean and approved.

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/218 to master January 30, 2023 16:02
@openjdk-notifier openjdk-notifier bot dismissed gnu-andrew’s stale review January 30, 2023 16:02

The base branch was changed.

@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout jdk-8287741-backport
git fetch https://git.openjdk.org/jdk8u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Jan 30, 2023

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 30, 2023
…mplete

Backport-of: 8d28734ede0ed3922c92451a172d1fa676e484e9
@openjdk
Copy link

openjdk bot commented Jan 30, 2023

@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@jerboaa
Copy link
Contributor Author

jerboaa commented Jan 30, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 30, 2023

Going to push as commit 563f7b5.
Since your change was applied there has been 1 commit pushed to the master branch:

  • b4ee9f8: 8301332: [8u] Fix writing of test files after the cgroups v2 backport

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 30, 2023
@openjdk openjdk bot closed this Jan 30, 2023
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jan 30, 2023
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jan 30, 2023
@openjdk
Copy link

openjdk bot commented Jan 30, 2023

@jerboaa Pushed as commit 563f7b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants