8299548: Fix hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java in 8u

[zzambers]

It was discovered [1] that following test is always skipped in 8u:
hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java

Test comes from JDK-8087291 [2] backport. Test is for 64-bit JDK only and uses following jtreg tag to test that:
@requires vm.bits == "64"

However vm.bits is not supported on 8u, where condition evaluates as always false, which results in test being skipped on all systems.

Fix:
Fixed by doing explicit check in test instead of using jtreg tag.

Testing:
Tested using github actions as test is part of hotspot/tier1.

[1] #182 (comment)
[2] https://bugs.openjdk.org/browse/JDK-8087291

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8299548: Fix hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java in 8u

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/222/head:pull/222
$ git checkout pull/222

Update a local copy of the PR:
$ git checkout pull/222
$ git pull https://git.openjdk.org/jdk8u-dev pull/222/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 222

View PR using the GUI difftool:
$ git pr show -t 222

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/222.diff

[bridgekeeper]

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (fc2959df)

[phohensee]

Lgtm.

[openjdk]

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8299548: Fix hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java in 8u

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 7ad517d: 8283277: ISO 4217 Amendment 171 Update

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[zzambers]

@phohensee thanks

[openjdk]

@zzambers
Your change (at version fc2959d) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 0f698da.
Since your change was applied there has been 1 commit pushed to the master branch:

• 7ad517d: 8283277: ISO 4217 Amendment 171 Update

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @zzambers Pushed as commit 0f698da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.