New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8289549: ISO 4217 Amendment 172 Update #224
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@gnu-andrew This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
Thanks. Flagged with |
I see |
/integrate |
Going to push as commit ca68579.
Your commit was automatically rebased without conflicts. |
@gnu-andrew Pushed as commit ca68579. |
Mostly clean backport of the next ISO 4217 update. Manual resolution was required on
tablea1.txt
as 8u is still using the olderFILEVERSION
at present.No data changes due to the last update already having the Sierra Leone changes, so this one is just a
dataversion
bump.Tests in
jdk/test/java/util/Currency
all pass.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/224/head:pull/224
$ git checkout pull/224
Update a local copy of the PR:
$ git checkout pull/224
$ git pull https://git.openjdk.org/jdk8u-dev pull/224/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 224
View PR using the GUI difftool:
$ git pr show -t 224
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/224.diff