Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294307: ISO 4217 Amendment 173 Update #225

Closed
wants to merge 1 commit into from

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Jan 6, 2023

Mostly clean backport of the next ISO 4217 update. Manual resolution was required on tablea1.txt as 8u is still using the older FILEVERSION at present.

No data changes due to the 171 update already having the Sierra Leone changes, so this one is just another dataversion bump.

Tests in jdk/test/java/util/Currency all pass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/225/head:pull/225
$ git checkout pull/225

Update a local copy of the PR:
$ git checkout pull/225
$ git pull https://git.openjdk.org/jdk8u-dev pull/225/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 225

View PR using the GUI difftool:
$ git pr show -t 225

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/225.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 6, 2023

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into pr/224 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e3eccbcbc2e27921c058d43b81fb113d10be2dab 8294307: ISO 4217 Amendment 173 Update Jan 6, 2023
@openjdk
Copy link

openjdk bot commented Jan 6, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 6, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 6, 2023

Webrevs

@openjdk openjdk bot mentioned this pull request Jan 6, 2023
3 tasks
Copy link
Contributor

@dimitryc dimitryc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@gnu-andrew
Copy link
Member Author

Looks good.

Thanks for the quick review. Flagged with jdk8u-fix-request.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2023

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into pr/224 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/224 to master January 10, 2023 02:50
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8294307
git fetch https://git.openjdk.org/jdk8u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Jan 10, 2023

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8294307: ISO 4217 Amendment 173 Update

Reviewed-by: dcherepanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 10, 2023
@openjdk
Copy link

openjdk bot commented Jan 10, 2023

@gnu-andrew Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@gnu-andrew
Copy link
Member Author

I see jdk8u-fix-yes.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 10, 2023

Going to push as commit 7c51dae.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 10, 2023
@openjdk openjdk bot closed this Jan 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2023
@openjdk
Copy link

openjdk bot commented Jan 10, 2023

@gnu-andrew Pushed as commit 7c51dae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants