New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8294307: ISO 4217 Amendment 173 Update #225
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks for the quick review. Flagged with |
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8294307
git fetch https://git.openjdk.org/jdk8u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@gnu-andrew This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
12e5b18
to
6281319
Compare
@gnu-andrew Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
I see /integrate |
Going to push as commit 7c51dae. |
@gnu-andrew Pushed as commit 7c51dae. |
Mostly clean backport of the next ISO 4217 update. Manual resolution was required on
tablea1.txt
as 8u is still using the olderFILEVERSION
at present.No data changes due to the 171 update already having the Sierra Leone changes, so this one is just another
dataversion
bump.Tests in
jdk/test/java/util/Currency
all pass.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/225/head:pull/225
$ git checkout pull/225
Update a local copy of the PR:
$ git checkout pull/225
$ git pull https://git.openjdk.org/jdk8u-dev pull/225/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 225
View PR using the GUI difftool:
$ git pr show -t 225
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/225.diff