New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8296239: ISO 4217 Amendment 174 Update #226
Conversation
👋 Welcome back andrew! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks for the quick review. Flagged with |
12e5b18
to
6281319
Compare
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8296239
git fetch https://git.openjdk.org/jdk8u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
caf780e
to
16f834d
Compare
@gnu-andrew Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
@gnu-andrew This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
I see /integrate |
Going to push as commit 1694a3a. |
@gnu-andrew Pushed as commit 1694a3a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Mostly clean backport of the next ISO 4217 update. Manual resolution was required on
tablea1.txt
as 8u is still using the olderFILEVERSION
at present, andValidateISO4217.java
, as it doesn't yet have JDK-8264792This one introduces Croatia's move to the Euro which occurred at the start of 2023.
Tests in
jdk/test/java/util/Currency
all pass.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/226/head:pull/226
$ git checkout pull/226
Update a local copy of the PR:
$ git checkout pull/226
$ git pull https://git.openjdk.org/jdk8u-dev pull/226/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 226
View PR using the GUI difftool:
$ git pr show -t 226
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/226.diff