8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR

[gnu-andrew]

This is a mostly clean backport from 11u. The only difference is the ProblemList.txt copyright header change didn't apply, so I just omitted this. It seems odd to include such a change when there are no changes to the content of the file. Maybe this makes sense for 11+ where the file is more in sync with trunk, but it will actually create problems in 8u backporting earlier fixes.

There are actually two fixes here, which may not be clear from the original bug:

1. The test data for the CurrencyFormat.java test still expects hr_HR to return Kn and hasn't been updated following Croatia's move to the Euro.
2. When that is corrected, there is still a mismatch because the JDK is not converting the currency code EUR to the Euro symbol. The same change to CurrencyNames_hr_HR.properties is required as was made to CurrencyNames_lt_LT.properties for Lithuania's move to the Euro in 2014

The above was verified by running the unpatched test against an unpatched JDK ("Wrong currency symbol for locale hr_HR, expected: Kn, got: EUR"), the patched test against an unpatched JDK ("Wrong currency symbol for locale hr_HR, expected: \u20ac, got: EUR") and the patched test against a patched JDK (both \u20AC). Only the last of these passes.

The patch also removes the long redundant time dependencies for Lithuania and Latvia.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR
• JDK-8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java

Reviewers

• Dmitry Cherepanov (@dimitryc - Reviewer)
• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/228/head:pull/228
$ git checkout pull/228

Update a local copy of the PR:
$ git checkout pull/228
$ git pull https://git.openjdk.org/jdk8u-dev pull/228/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 228

View PR using the GUI difftool:
$ git pr show -t 228

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/228.diff

[bridgekeeper]

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issues from the original commit.

[mlbridge]

Webrevs

• 00: Full (0ae029a8)

[gnu-andrew]

Failures appear to be down to download errors, nothing to do with the patch.

[dimitryc]

Looks good

[openjdk]

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR
8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java

Reviewed-by: dcherepanov, sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[gnu-andrew]

I see jdk8u-fix-yes.

/integrate

[gnu-andrew]

Test failure is a timeout on gc/6581734/Test6581734.java. Is this a known failure?

[openjdk]

Going to push as commit a5c3ebe.
Since your change was applied there have been 2 commits pushed to the master branch:

• 9d954b9: 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun
• 5a3fc18: 8299804: Fix non-portable code in hotspot shell tests in 8u

Your commit was automatically rebased without conflicts.

[openjdk]

@gnu-andrew Pushed as commit a5c3ebe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.