Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274751: Drag And Drop hangs on Windows #23

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Mar 28, 2022

Hi all,
This pull request contains a backport of commit 7a0a6c95 from the openjdk/jdk repository.
The commit being backported was authored by Dmitry Markov on 24 Jan 2022 and was reviewed by Alexey Ivanov, Phil Race and Sergey Bylokhov.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/23/head:pull/23
$ git checkout pull/23

Update a local copy of the PR:
$ git checkout pull/23
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/23/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23

View PR using the GUI difftool:
$ git pr show -t 23

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/23.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 28, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7a0a6c95a53c6cb3340328d6543a97807320b740 8274751: Drag And Drop hangs on Windows Mar 28, 2022
@openjdk
Copy link

openjdk bot commented Mar 28, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Mar 28, 2022
@mrserb
Copy link
Member Author

mrserb commented Mar 28, 2022

/clean One conflict of the copyright date is fixed manually.

@openjdk openjdk bot added the clean label Mar 28, 2022
@openjdk
Copy link

openjdk bot commented Mar 28, 2022

@mrserb This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Mar 28, 2022

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8274751: Drag And Drop hangs on Windows

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 28, 2022
@mrserb mrserb marked this pull request as ready for review March 28, 2022 06:30
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 28, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 28, 2022

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Mar 30, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 30, 2022

Going to push as commit e403fd5.
Since your change was applied there has been 1 commit pushed to the master branch:

  • f8a6695: 8274658: ISO 4217 Amendment 170 Update

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 30, 2022
@openjdk openjdk bot closed this Mar 30, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 30, 2022
@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@mrserb Pushed as commit e403fd5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the mrserb-backport-7a0a6c95 branch March 30, 2022 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant