8185736: missing default exception handler in calls to rethrow_Stub

[dongbohe]

Hi,

I would like to backport this patch to fix missing of default exception handler in catch table produced by C2.
Patch apply cleanly, worked correctly after patch.

Testing: Performed hotspot jtreg test on linux x86-64 platforms with -XX:-TieredCompilation -Xcomp options.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8185736: missing default exception handler in calls to rethrow_Stub

Reviewers

• Roland Westrelin (@rwestrel - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/231/head:pull/231
$ git checkout pull/231

Update a local copy of the PR:
$ git checkout pull/231
$ git pull https://git.openjdk.org/jdk8u-dev pull/231/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 231

View PR using the GUI difftool:
$ git pr show -t 231

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/231.diff

[bridgekeeper]

👋 Welcome back dongbohe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@dongbohe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8185736: missing default exception handler in calls to rethrow_Stub

Reviewed-by: roland

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 3d1fc4b: 8303462: Bump update version of OpenJDK: 8u382

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rwestrel) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 01: Full - Incremental (50f39316)
• 00: Full (1f47444d)

[bridgekeeper]

@dongbohe This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[jerboaa]

/reviewer 1

[jerboaa]

@rwestrel Could you please take a look at this backport? Is this safe to approve in your opinion?

[openjdk]

@jerboaa Only the author (@dongbohe) is allowed to issue the reviewer command.

[jerboaa]

/reviewers 1

[jerboaa]

/reviewers 1 reviewer

[openjdk]

@jerboaa
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 1 (with at least 1 Reviewer).

[openjdk]

@jerboaa
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 1 (with at least 1 Reviewer).

[dongbohe]

This crash can always be reproduced in our environment, and worked correctly after patch. Unfortunately, it is difficult to extract a simple test case.

[rwestrel]

Looks reasonable to me.

[dongbohe]

Thank you for your review, Roland.

[dongbohe]

It seems that the failed tests in the pre-test were not caused by this PR and I couldn't reproduce this in my environment.
It appears to be a random cms crash, I created JDK-8303159 to track this issue.

[dongbohe]

Got the jdk8u-fix-yes.
/integrate

[openjdk]

@dongbohe
Your change (at version 50f3931) is now ready to be sponsored by a Committer.

[rwestrel]

/sponsor

[openjdk]

Going to push as commit eb2aee6.
Since your change was applied there has been 1 commit pushed to the master branch:

• 3d1fc4b: 8303462: Bump update version of OpenJDK: 8u382

Your commit was automatically rebased without conflicts.

[openjdk]

@rwestrel @dongbohe Pushed as commit eb2aee6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.