Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282947: JFR: Dump on shutdown live-locks in some conditions #233

Closed
wants to merge 1 commit into from

Conversation

judovana
Copy link
Contributor

@judovana judovana commented Jan 19, 2023

Reviewed-by: mgronlun


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282947: JFR: Dump on shutdown live-locks in some conditions ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/233/head:pull/233
$ git checkout pull/233

Update a local copy of the PR:
$ git checkout pull/233
$ git pull https://git.openjdk.org/jdk8u-dev pull/233/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 233

View PR using the GUI difftool:
$ git pr show -t 233

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/233.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 19, 2023

👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 19, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 19, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 19, 2023

@judovana Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@judovana
Copy link
Contributor Author

closing to pick up freshly enabled GithubActions

@judovana judovana closed this Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
2 participants