Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8282947: JFR: Dump on shutdown live-locks in some conditions #234

Closed
wants to merge 5 commits into from
Closed

8282947: JFR: Dump on shutdown live-locks in some conditions #234

wants to merge 5 commits into from

Conversation

judovana
Copy link
Contributor

@judovana judovana commented Jan 19, 2023 •
edited by openjdk bot
Loading

Reviewed-by: mgronlun

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282947: JFR: Dump on shutdown live-locks in some conditions

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/234/head:pull/234
$ git checkout pull/234

Update a local copy of the PR:
$ git checkout pull/234
$ git pull https://git.openjdk.org/jdk8u-dev pull/234/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 234

View PR using the GUI difftool:
$ git pr show -t 234

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/234.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 19, 2023

👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 19, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 19, 2023 •
edited
Loading

Webrevs

@phohensee
Copy link
Member

Please change the PR title to "Backport 63eb0b7e8606dd9cd145e92eeeb744ff5b7be569".

@judovana judovana changed the title 8282947: JFR: Dump on shutdown live-locks in some conditions Backport 63eb0b7e8606dd9cd145e92eeeb744ff5b7be569 Jan 19, 2023
@openjdk openjdk bot changed the title Backport 63eb0b7e8606dd9cd145e92eeeb744ff5b7be569 8282947: JFR: Dump on shutdown live-locks in some conditions Jan 19, 2023
@openjdk
Copy link

openjdk bot commented Jan 19, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jan 19, 2023
@judovana
Copy link
Contributor Author

Actually, the lib should be

@library /lib /

?

@judovana
Copy link
Contributor Author

judovana commented Jan 19, 2023 •
edited
Loading

Hmm. The test fails. I need to elaborate.

https://github.com/judovana/jdk-tester/actions/runs/3959120089/jobs/6785321268

@judovana
Copy link
Contributor Author

Hello! I had adapted the test. It sitll represents issue - fails on non patched jdk, and now correctly passes on patched jdk. Automated test is now running for both jfr group and jdk group. So far so good.

@judovana
Removed jdk8 incompatible -Xlog:jfr
39d3b24 
it do not affect tests behavior
@judovana
Copy link
Contributor Author

The pass can be visible on https://github.com/judovana/jdk-tester/actions/runs/3988734842/jobs/6840282234#step:12:187

What now?

@jerboaa
Copy link
Contributor

jerboaa commented Jan 24, 2023

What now?

See Contributing section in https://wiki.openjdk.org/display/jdk8u

@judovana
Copy link
Contributor Author

Thank you:) Label added. All testing on my end done. Waiting for review.

@zzambers
Copy link
Contributor

I have tried to run jdk_jfr group on master, 3 failures are not regressions (fail both with and without changes):
https://github.com/zzambers/jdk-tester/actions/runs/3997510473/jobs/6858945097#step:12:2527

Failures are:

jdk/jfr/event/compiler/TestCompilerCompile.java
jdk/jfr/event/sampling/TestNative.java
jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java

@judovana
Copy link
Contributor Author

On my local machine only the jdk/jfr/event/sampling/TestNative.java is failing. I had fixed it like this: #235

@zzambers
Copy link
Contributor

On my local machine only the jdk/jfr/event/sampling/TestNative.java is failing. I had fixed it like this: #235

Interesting, so these 2 seem environment/test machine speed sensitive
TestCompilerCompile - timeout actually
TestJcmdDumpPathToGCRoots - ?

phohensee
phohensee approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Jan 25, 2023

@judovana This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8282947: JFR: Dump on shutdown live-locks in some conditions

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • a5bd901: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts
  • 75fd39f: 8282398: EndingDotHostname.java test fails because SSL cert expired
  • 8d2f7e0: 8292541: [Metrics] Reported memory limit may exceed physical machine memory
  • 5525464: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 25, 2023
@judovana

This comment was marked as off-topic.

Sign in to view
@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 26, 2023
@openjdk
Copy link

openjdk bot commented Jan 26, 2023

@judovana
Your change (at version 39d3b24) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Jan 26, 2023

@judovana Please only integrate once you have approval via jdk8u-fix-yes on the bug.

@jerboaa jerboaa mentioned this pull request Jan 31, 2023
Closed
3 tasks
@phohensee
Copy link
Member

@judovana, you must add the jdk8u-fix-request label to the JBS issue, as well as a "Fix Request (8u)" comment detailing the testing and risk associated with the backport.

@judovana
Copy link
Contributor Author

judovana commented Feb 7, 2023

@judovana, you must add the jdk8u-fix-request label to the JBS issue, as well as a "Fix Request (8u)" comment detailing the testing and risk associated with the backport.

The jdk8u-fix-request somehow disapeard. Readded. The "Fix Request (8u)" is already there - https://bugs.openjdk.org/browse/JDK-8282947?focusedCommentId=14554615&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14554615

@judovana judovana mentioned this pull request Feb 13, 2023
Closed
3 tasks
@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 15, 2023

Going to push as commit ec53e00.
Since your change was applied there have been 33 commits pushed to the master branch:

  • c183dc5: 8142540: [TEST_BUG] Test sun/awt/dnd/8024061/bug8024061.java fails on ubuntu
  • cbde744: 8137101: [TEST_BUG] javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java failure due to timing
  • 29a1b79: 7124238: [macosx] Font in BasicHTML document is bigger than it should be
  • 3af19d3: 8282511: Use fixed certificate validation date in SSLExampleCert template
  • 8995356: 6734341: REGTEST fails: SelectionAutoscrollTest.html
  • 11a96a7: 8156581: Cleanup of ProblemList.txt
  • fd41600: 8205959: Do not restart close if errno is EINTR
  • b71f59b: 8298027: Remove SCCS id's from awt jtreg tests
  • fbaabf3: 8301620: [8u] some shell tests are passed but have unexpected operator errors
  • 8c42e20: 8287109: Distrust.java failed with CertificateExpiredException
  • ... and 23 more: https://git.openjdk.org/jdk8u-dev/compare/a318e48e205acd2e15c50afb9c70c4106ed72463...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 15, 2023
@openjdk openjdk bot closed this Feb 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 15, 2023
@openjdk
Copy link

openjdk bot commented Feb 15, 2023

@phohensee @judovana Pushed as commit ec53e00.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phohensee phohensee phohensee approved these changes

Assignees
No one assigned
Labels
backport integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@judovana @phohensee @jerboaa @zzambers @egahlin