-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 #244
Conversation
👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@ktakakuri This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 40 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @jerboaa) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@ktakakuri |
/sponsor |
Going to push as commit b057084.
Your commit was automatically rebased without conflicts. |
@phohensee @ktakakuri Pushed as commit b057084. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a backport of JDK-8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11.
The original patch accidentally added "out", but it was removed in JDK-8276623.
This PR backports 8275650 without "out".
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/244/head:pull/244
$ git checkout pull/244
Update a local copy of the PR:
$ git checkout pull/244
$ git pull https://git.openjdk.org/jdk8u-dev pull/244/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 244
View PR using the GUI difftool:
$ git pr show -t 244
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/244.diff