Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 #244

Closed
wants to merge 1 commit into from

Conversation

ktakakuri
Copy link
Contributor

@ktakakuri ktakakuri commented Jan 26, 2023

This is a backport of JDK-8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11.
The original patch accidentally added "out", but it was removed in JDK-8276623.
This PR backports 8275650 without "out".


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/244/head:pull/244
$ git checkout pull/244

Update a local copy of the PR:
$ git checkout pull/244
$ git pull https://git.openjdk.org/jdk8u-dev pull/244/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 244

View PR using the GUI difftool:
$ git pr show -t 244

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/244.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 26, 2023

👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 32895ac60949ccceb0a3d25c73ec5e3a00c29593 8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11 Jan 26, 2023
@openjdk
Copy link

openjdk bot commented Jan 26, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 26, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 26, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Jan 26, 2023

@ktakakuri This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11

Reviewed-by: phh, sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

  • f142618: 8075964: Test java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html fails intermittently with timeout error
  • 456d7ac: 8239827: The test OpenByUNCPathNameTest.java should be changed to be manual
  • dd8dd7b: 8042098: [TESTBUG] Test sun/java2d/AcceleratedXORModeTest.java fails on Windows
  • 85050ef: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails
  • 92c9aed: 8039888: [TEST_BUG] keyboard garbage after javax/swing/plaf/windows/WindowsRootPaneUI/WrongAltProcessing/WrongAltProcessing.java
  • 5274069: 8196467: javax/swing/JInternalFrame/Test6325652.java fails
  • c3c871e: 8159135: [PIT] javax/swing/JMenuItem/8152981/MenuItemIconTest.java always fail
  • 8192d03: 8293767: AWT test TestSinhalaChar.java has old SCCS markings
  • d0cbcc5: 8301122: [8u] Fix unreliable vs2010 download link
  • a5bd901: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts
  • ... and 30 more: https://git.openjdk.org/jdk8u-dev/compare/a5c3ebe614d5d1595098bb402ae94e6ba5265171...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 26, 2023
@ktakakuri
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 29, 2023
@openjdk
Copy link

openjdk bot commented Jan 29, 2023

@ktakakuri
Your change (at version e43c895) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 30, 2023

Going to push as commit b057084.
Since your change was applied there have been 41 commits pushed to the master branch:

  • ab678bc: 8283606: Tests may fail with zh locale on MacOS
  • f142618: 8075964: Test java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html fails intermittently with timeout error
  • 456d7ac: 8239827: The test OpenByUNCPathNameTest.java should be changed to be manual
  • dd8dd7b: 8042098: [TESTBUG] Test sun/java2d/AcceleratedXORModeTest.java fails on Windows
  • 85050ef: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails
  • 92c9aed: 8039888: [TEST_BUG] keyboard garbage after javax/swing/plaf/windows/WindowsRootPaneUI/WrongAltProcessing/WrongAltProcessing.java
  • 5274069: 8196467: javax/swing/JInternalFrame/Test6325652.java fails
  • c3c871e: 8159135: [PIT] javax/swing/JMenuItem/8152981/MenuItemIconTest.java always fail
  • 8192d03: 8293767: AWT test TestSinhalaChar.java has old SCCS markings
  • d0cbcc5: 8301122: [8u] Fix unreliable vs2010 download link
  • ... and 31 more: https://git.openjdk.org/jdk8u-dev/compare/a5c3ebe614d5d1595098bb402ae94e6ba5265171...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 30, 2023
@openjdk openjdk bot closed this Jan 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 30, 2023
@openjdk
Copy link

openjdk bot commented Jan 30, 2023

@phohensee @ktakakuri Pushed as commit b057084.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@ktakakuri ktakakuri deleted the 8275650 branch February 21, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants