Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233570: [TESTBUG] HTMLEditorKit test bug5043626.java is failing on macos #247

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jan 27, 2023

Backport to fix a test bug.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8233570: [TESTBUG] HTMLEditorKit test bug5043626.java is failing on macos

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/247/head:pull/247
$ git checkout pull/247

Update a local copy of the PR:
$ git checkout pull/247
$ git pull https://git.openjdk.org/jdk8u-dev pull/247/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 247

View PR using the GUI difftool:
$ git pr show -t 247

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/247.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 27, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a5b42ec8b29249814dda28e751ee363869e98da0 8233570: [TESTBUG] HTMLEditorKit test bug5043626.java is failing on macos Jan 27, 2023
@openjdk
Copy link

openjdk bot commented Jan 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jan 27, 2023
@mrserb mrserb marked this pull request as ready for review January 28, 2023 03:40
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 28, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 28, 2023

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Jan 28, 2023

/clean The change for the problemlist is skipped.

@openjdk openjdk bot added the clean label Jan 28, 2023
@openjdk
Copy link

openjdk bot commented Jan 28, 2023

@mrserb This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jan 28, 2023

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8233570: [TESTBUG] HTMLEditorKit test bug5043626.java is failing on macos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 28, 2023
@mrserb
Copy link
Member Author

mrserb commented Jan 30, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 30, 2023

Going to push as commit 604e582.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 563f7b5: 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete
  • b4ee9f8: 8301332: [8u] Fix writing of test files after the cgroups v2 backport
  • 36f6f17: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller
  • b057084: 8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11
  • ab678bc: 8283606: Tests may fail with zh locale on MacOS

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 30, 2023
@openjdk openjdk bot closed this Jan 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 30, 2023
@openjdk
Copy link

openjdk bot commented Jan 30, 2023

@mrserb Pushed as commit 604e582.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the mrserb-backport-a5b42ec8 branch January 30, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant