8278138: OpenJDK8 fails to start on Windows 8.1 after upgrading compiler to VS2017

[ktakakuri]

Could you please review the 8278138 bug fixes?

This problem is caused by missing DLL's which vcruntime140.dll depends on.
I think it is needed to copy the missing DLL's into jdk/bin as like jdk/jre/bin.
I fix to copy api-ms-win-*.dll files to jdk/bin when images directory is created.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• JDK-8278138: OpenJDK8 fails to start on Windows 8.1 after upgrading compiler to VS2017

Reviewers

• Joakim Nordström (@jaokim - no project role)
• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/25/head:pull/25
$ git checkout pull/25

Update a local copy of the PR:
$ git checkout pull/25
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/25/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25

View PR using the GUI difftool:
$ git pr show -t 25

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/25.diff

[bridgekeeper]

👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (be11289e)
• 00: Full (dda73cdd)

[ktakakuri]

Could anyone review the fix please?

[ktakakuri]

Could someone please review this pull request?

[jaokim]

Hi,
Thank you for looking into this.
I've found that only copying the api-ms-* DLLs isn't sufficient. You also need to copy ucrtbase.dll among others. Instead of relying on the name, you can simply add all files from the the redistributable UCRT directory, in the same manner as in CopyFiles.gmk.

[ktakakuri]

Hi, Thank you for looking into this. I've found that only copying the api-ms-* DLLs isn't sufficient. You also need to copy ucrtbase.dll among others. Instead of relying on the name, you can simply add all files from the the redistributable UCRT directory, in the same manner as in CopyFiles.gmk.

Thank you for your review.
I think your comments are correct.

[ktakakuri]

@jaokim
I have committed your fix.
Could you please review it again?

[jaokim]

Changes looks good to me!

[openjdk]

@ktakakuri This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8278138: OpenJDK8 fails to start on Windows 8.1 after upgrading compiler to VS2017

Reviewed-by: jnordstrom, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

• 680b09c: 8168926: C2: Bytecode escape analyzer crashes due to stack overflow
• 51f69d9: 8221988: add possibility to build with Visual Studio 2019
• 1b3e8ea: 8170530: bash configure output contains a typo in a suggested library name
• 1067c54: 8235211: serviceability/attach/RemovingUnixDomainSocketTest.java fails with AttachNotSupportedException: Unable to open socket file
• 1bc3be2: Merge
• ee82a7d: 8282458: Update .jcheck/conf file for 8u move to git
• d91ee59: Added tag jdk8u332-ga for changeset 37aca7715d13
• 607b14e: 8285445: cannot open file "NUL:"
• 62defc3: 8284772: 8u GHA: Use GCC Major Version Dependencies Only
• 65c4a5d: Merge
• ... and 32 more: https://git.openjdk.java.net/jdk8u-dev/compare/57d8d29080414dd038fffff1b97d97f3ab3f1570...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[ktakakuri]

/integrate

[openjdk]

@ktakakuri
Your change (at version be11289) is now ready to be sponsored by a Committer.

[ktakakuri]

@erikj79
Would you be willing to be a sponsor?

[jaokim]

This needs to be approved according to https://wiki.openjdk.java.net/display/jdk8u/Main#Main-FixApprovals
I'm in the process of adding the needed labels to the JBS issue, and then a maintainer will take care of the approval.

[jerboaa]

@ktakakuri The issue this is referencing is resolved. I'm guessing it got resolved with a push to Oracle's JDK 8 fork. The commit for this isn't public so we need to do the SKARA trick to mention the backport bug like so: Backport JDK-8278138. I.e. Please change the PR title to Backport JDK-8278138. It's strange that skara bots don't flag this with a warning (it's not labelled as a backport and the bug is not open anymore).

[jerboaa]

Also, please enable PR checks. Perhaps a merge from master would do that.

[jerboaa]

@ktakakuri Once this is being recognized as a backport I'll sponsor it for you.

[openjdk]

This backport pull request has now been updated with the original issue, but not the original commit. If you have the original commit hash, please update the pull request title with Backport <hash>.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit 6b94b65.
Since your change was applied there have been 42 commits pushed to the master branch:

• 680b09c: 8168926: C2: Bytecode escape analyzer crashes due to stack overflow
• 51f69d9: 8221988: add possibility to build with Visual Studio 2019
• 1b3e8ea: 8170530: bash configure output contains a typo in a suggested library name
• 1067c54: 8235211: serviceability/attach/RemovingUnixDomainSocketTest.java fails with AttachNotSupportedException: Unable to open socket file
• 1bc3be2: Merge
• ee82a7d: 8282458: Update .jcheck/conf file for 8u move to git
• d91ee59: Added tag jdk8u332-ga for changeset 37aca7715d13
• 607b14e: 8285445: cannot open file "NUL:"
• 62defc3: 8284772: 8u GHA: Use GCC Major Version Dependencies Only
• 65c4a5d: Merge
• ... and 32 more: https://git.openjdk.java.net/jdk8u-dev/compare/57d8d29080414dd038fffff1b97d97f3ab3f1570...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @ktakakuri Pushed as commit 6b94b65.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.