Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7124381: DragSourceListener.dragDropEnd() never been called on completion of dnd operation #256

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Feb 1, 2023

Hi all,
This pull request contains a backport of commit af802cb5 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 25 Apr 2016 and was reviewed by Yuri Nesterenko and Semyon Sadetsky.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-7124381: DragSourceListener.dragDropEnd() never been called on completion of dnd operation

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/256/head:pull/256
$ git checkout pull/256

Update a local copy of the PR:
$ git checkout pull/256
$ git pull https://git.openjdk.org/jdk8u-dev pull/256/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 256

View PR using the GUI difftool:
$ git pr show -t 256

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/256.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport af802cb54114616dc74217ac91a65ecdb15d144f 7124381: DragSourceListener.dragDropEnd() never been called on completion of dnd operation Feb 1, 2023
@openjdk
Copy link

openjdk bot commented Feb 1, 2023

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review February 1, 2023 01:31
@openjdk
Copy link

openjdk bot commented Feb 1, 2023

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7124381: DragSourceListener.dragDropEnd() never been called on completion of dnd operation

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 1, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2023

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Feb 1, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 1, 2023

Going to push as commit 784f71f.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 57bc209: 8301550: [8u] Enable additional linux build testing in GitHub

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 1, 2023
@openjdk openjdk bot closed this Feb 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 1, 2023
@openjdk
Copy link

openjdk bot commented Feb 1, 2023

@mrserb Pushed as commit 784f71f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant