Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287109: Distrust.java failed with CertificateExpiredException #258

Closed
wants to merge 1 commit into from

Conversation

theaoqi
Copy link
Member

@theaoqi theaoqi commented Feb 1, 2023

I request the backport for parity with Oracle JDK 8. The update of ProblemList is not needed, the rest is clean (with path adjustment). This backport is only a test change, so the risk is low. The backport fixes the test failure.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287109: Distrust.java failed with CertificateExpiredException

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/258/head:pull/258
$ git checkout pull/258

Update a local copy of the PR:
$ git checkout pull/258
$ git pull https://git.openjdk.org/jdk8u-dev pull/258/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 258

View PR using the GUI difftool:
$ git pr show -t 258

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/258.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2023

👋 Welcome back aoqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5b7d066ca5cb68e07a704d3ce13283761c1cf3ad 8287109: Distrust.java failed with CertificateExpiredException Feb 1, 2023
@openjdk
Copy link

openjdk bot commented Feb 1, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 1, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2023

Webrevs

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Feb 1, 2023

@theaoqi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8287109: Distrust.java failed with CertificateExpiredException

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 784f71f: 7124381: DragSourceListener.dragDropEnd() never been called on completion of dnd operation
  • 57bc209: 8301550: [8u] Enable additional linux build testing in GitHub

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 1, 2023
@theaoqi
Copy link
Member Author

theaoqi commented Feb 8, 2023

Got the jdk8u-fix-yes.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 8, 2023
@openjdk
Copy link

openjdk bot commented Feb 8, 2023

@theaoqi
Your change (at version a0486fd) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Feb 8, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 8, 2023

Going to push as commit 8c42e20.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 784f71f: 7124381: DragSourceListener.dragDropEnd() never been called on completion of dnd operation
  • 57bc209: 8301550: [8u] Enable additional linux build testing in GitHub

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 8, 2023
@openjdk openjdk bot closed this Feb 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 8, 2023
@openjdk
Copy link

openjdk bot commented Feb 8, 2023

@jerboaa @theaoqi Pushed as commit 8c42e20.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants