Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301631: [8u] Enable full builds for additional Linux builds #259

Closed
wants to merge 2 commits into from

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Feb 1, 2023

Let's try to enable full builds for the additional (i.e. cross-compilation to s390x, aarch64, arm & ppc64le) builds, so the JDK native code gets built as well.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8301631 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8301631: [8u] Enable full builds for additional Linux builds (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/259/head:pull/259
$ git checkout pull/259

Update a local copy of the PR:
$ git checkout pull/259
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/259/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 259

View PR using the GUI difftool:
$ git pr show -t 259

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/259.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2023

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 1, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2023

Webrevs

@zzambers
Copy link
Contributor

zzambers commented Feb 6, 2023

Seems, there are problems with Ubuntu repos, used by GitHub runners, at the moment:
actions/runner-images#7048
:(

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2023

@gnu-andrew This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@gnu-andrew
Copy link
Member Author

I'll have another look at this after the 8u372 release is out of the way. I'll likely include a workaround for the Ubuntu issue I've seen suggested so we don't hit that again in future.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2023

@gnu-andrew This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2023

@gnu-andrew This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this May 23, 2023
@gnu-andrew
Copy link
Member Author

/open

@openjdk openjdk bot reopened this Aug 7, 2023
@openjdk
Copy link

openjdk bot commented Aug 7, 2023

@gnu-andrew This pull request is now open

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 4, 2023

@gnu-andrew This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2023

@gnu-andrew This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
2 participants