Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7124238: [macosx] Font in BasicHTML document is bigger than it should be #262

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Feb 2, 2023

clean backport of the new test added in JDK9. tested on Windows/Linux/macOS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-7124238: [macosx] Font in BasicHTML document is bigger than it should be

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/262/head:pull/262
$ git checkout pull/262

Update a local copy of the PR:
$ git checkout pull/262
$ git pull https://git.openjdk.org/jdk8u-dev pull/262/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 262

View PR using the GUI difftool:
$ git pr show -t 262

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/262.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 2, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8ccf075f78b5645dd186d11637bd11d7e6938b86 7124238: [macosx] Font in BasicHTML document is bigger than it should be Feb 2, 2023
@openjdk
Copy link

openjdk bot commented Feb 2, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Feb 2, 2023
@mrserb mrserb marked this pull request as ready for review February 2, 2023 23:49
@mrserb
Copy link
Member Author

mrserb commented Feb 2, 2023

/clean Path is changed only.

@openjdk openjdk bot added rfr Pull request is ready for review clean labels Feb 2, 2023
@openjdk
Copy link

openjdk bot commented Feb 2, 2023

@mrserb This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Feb 2, 2023

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7124238: [macosx] Font in BasicHTML document is bigger than it should be

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • fbaabf3: 8301620: [8u] some shell tests are passed but have unexpected operator errors
  • 8c42e20: 8287109: Distrust.java failed with CertificateExpiredException

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 2, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 2, 2023

Webrevs

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Path verified as adjusted for 8u. Approved.

@mrserb
Copy link
Member Author

mrserb commented Feb 13, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 13, 2023

Going to push as commit 29a1b79.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 3af19d3: 8282511: Use fixed certificate validation date in SSLExampleCert template
  • 8995356: 6734341: REGTEST fails: SelectionAutoscrollTest.html
  • 11a96a7: 8156581: Cleanup of ProblemList.txt
  • fd41600: 8205959: Do not restart close if errno is EINTR
  • b71f59b: 8298027: Remove SCCS id's from awt jtreg tests
  • fbaabf3: 8301620: [8u] some shell tests are passed but have unexpected operator errors
  • 8c42e20: 8287109: Distrust.java failed with CertificateExpiredException

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 13, 2023
@openjdk openjdk bot closed this Feb 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 13, 2023
@openjdk
Copy link

openjdk bot commented Feb 13, 2023

@mrserb Pushed as commit 29a1b79.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the 7124238 branch February 13, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants