-
Notifications
You must be signed in to change notification settings - Fork 171
8205959: Do not restart close if errno is EINTR #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back andrew! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
@gnu-andrew This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Thanks Sergey. Flagged for approval. |
|
I see |
|
@gnu-andrew Pushed as commit fd41600. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
Hello.. we have a serious problem.. after Java release 8u321, Qualys scans trigger port connections which remain in CLOSE_WAIT state. We tried 8u361, 8u371, 8u391 and I just tested the latest release 8u401.. same problem.. netstat -pant | egrep CLOSE_WAITtcp6 204 0 10.171.12.150:8443 10.171.12.184:56834 CLOSE_WAIT 31014/java |
|
Well, maybe our problem is not related to this change.. But, just in case anybody is watching.. We tested all these builds with Qualys, they all functioned as expected: server-jre-8u331-linux-x64.tar.gz server-jre-8u333-linux-x64.tar.gz server-jre-8u341-linux-x64.tar.gz server-jre-8u351-linux-x64.tar.gz this one is - and all the ones following it are - broken: server-jre-8u361-linux-x64.tar.gz . . . |
Bug fix avoiding misuse of
close()Code changes backport cleanly. The copyright header had to be adjusted as the 8u header was still 2016, not 2017.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/267/head:pull/267$ git checkout pull/267Update a local copy of the PR:
$ git checkout pull/267$ git pull https://git.openjdk.org/jdk8u-dev pull/267/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 267View PR using the GUI difftool:
$ git pr show -t 267Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/267.diff