8298108: Add a regression test for JDK-8297684 #269

jerboaa · 2023-02-27T19:13:58Z

Please review this backport of the regression test for a critical fix which we've included with the January CPU update. The fix was https://bugs.openjdk.org/browse/JDK-8280890

This patch adds an additional regression test which was seen in the wild with JDK 17. The patch isn't clean since the test library in jdk8u is different so needed a bit of a different setup routine for getting the jar with the provider created. Additionally, in jdk 8 the property to add providers is setting java.ext.dirs=... over java.locale.providers=SPI in later JDKs.

Testing: The test passes for me on the current dev tree and fails with the fix from JDK-8280890 reverted.

Thoughts?

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issues

JDK-8298108: Add a regression test for JDK-8297684
JDK-8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows

Reviewers

Paul Hohensee (@phohensee - Reviewer) ⚠️ Review applies to 2e937ca2
Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/269/head:pull/269
$ git checkout pull/269

Update a local copy of the PR:
$ git checkout pull/269
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/269/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 269

View PR using the GUI difftool:
$ git pr show -t 269

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/269.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-02-27T19:14:31Z

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-02-27T19:23:48Z

This backport pull request has now been updated with issue from the original commit.

mlbridge · 2023-02-27T19:34:10Z

Webrevs

01: Full - Incremental (203a9ef6)
00: Full (2e937ca2)

phohensee

Lgtm.

openjdk · 2023-03-01T16:54:00Z

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8298108: Add a regression test for JDK-8297684
8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

54208fc: 8305975: Add TWCA Global Root CA
20b4c70: 8072678: Wrong exception messages in java.awt.color.ICC_ColorSpace
764dbd5: 8307310: Backport the tests for JDK-8058969 and JDK-8039271 to the OpenJDK8
8562298: 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped
c7c080a: 8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4
3e69b49: 8307531: [aarch64] JDK8 single-step debugging is extremely slow
4328fec: 8303028: Update system property for Java SE specification maintenance version
3d9e8d0: 8305681: Allow additional characters for GB18030-2022 (Level 2) support
9740c24: 8301400: Allow additional characters for GB18030-2022 support
3147b1b: 8305165: [8u] ServiceThread::nmethods_do is not called to keep nmethods from being zombied while in the queue
... and 44 more: https://git.openjdk.org/jdk8u-dev/compare/b51619d24e0643aa0afdba87ac20b371dbb594e8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

jerboaa · 2023-03-03T13:47:41Z

Thanks for the review, Paul!

bridgekeeper · 2023-03-31T17:26:39Z

@jerboaa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

jerboaa · 2023-04-03T08:46:17Z

Please keep it open, bot.

gnu-andrew

I've queried a couple of minor issues, but generally looks like a good conversion to 8u. It does seem that installing the provider in 8u is quite awkward. Is there no way to do it with just the JAR?

jdk/test/java/security/SignedJar/spi-calendar-provider/TestSPISigned.java

gnu-andrew · 2023-04-04T18:12:34Z

We should also probably reference JDK-8298271 in this PR to make it clear that the issue is also resolved for 8u (it was effectively "fixed" by not using a hardcoded path separator in the first place)

jerboaa · 2023-04-04T18:50:03Z

/issue add JDK-8298271

openjdk · 2023-04-04T18:51:23Z

@jerboaa
Adding additional issue to issue list: 8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows.

jerboaa · 2023-04-04T19:04:54Z

It does seem that installing the provider in 8u is quite awkward. Is there no way to do it with just the JAR?

Agreed. I couldn't get it to work otherwise, though. The calendar providing jar needs to be in the java.ext.dirs list of directories and the jar have the service provider (via ServiceLoader).

jerboaa · 2023-04-04T19:05:20Z

We should also probably reference JDK-8298271 in this PR to make it clear that the issue is also resolved for 8u (it was effectively "fixed" by not using a hardcoded path separator in the first place)

Done.

jerboaa · 2023-04-19T18:18:54Z

@gnu-andrew Is there anything else you need my action on?

bridgekeeper · 2023-05-17T23:54:27Z

@jerboaa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

jerboaa · 2023-05-19T08:49:48Z

@gnu-andrew Ping? Could you please take another look. Thanks!

gnu-andrew

No, nothing more needed, only just seen the updated version. Looks fine now, sorry for the delay!
Approved for 8u.

jerboaa · 2023-05-25T17:28:58Z

Thanks for taking a look!

/integrate

openjdk · 2023-05-25T17:30:16Z

Going to push as commit 29ba98e.
Since your change was applied there have been 54 commits pushed to the master branch:

54208fc: 8305975: Add TWCA Global Root CA
20b4c70: 8072678: Wrong exception messages in java.awt.color.ICC_ColorSpace
764dbd5: 8307310: Backport the tests for JDK-8058969 and JDK-8039271 to the OpenJDK8
8562298: 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped
c7c080a: 8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4
3e69b49: 8307531: [aarch64] JDK8 single-step debugging is extremely slow
4328fec: 8303028: Update system property for Java SE specification maintenance version
3d9e8d0: 8305681: Allow additional characters for GB18030-2022 (Level 2) support
9740c24: 8301400: Allow additional characters for GB18030-2022 support
3147b1b: 8305165: [8u] ServiceThread::nmethods_do is not called to keep nmethods from being zombied while in the queue
... and 44 more: https://git.openjdk.org/jdk8u-dev/compare/b51619d24e0643aa0afdba87ac20b371dbb594e8...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-05-25T17:30:28Z

@jerboaa Pushed as commit 29ba98e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Add regression test for JDK-8297684

2e937ca

openjdk bot changed the title ~~Backport 4da8411674b7515310000bd8243860bc73f9a03d~~ 8298108: Add a regression test for JDK-8297684 Feb 27, 2023

openjdk bot added backport rfr Pull request is ready for review labels Feb 27, 2023

phohensee approved these changes Mar 1, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 1, 2023

gnu-andrew reviewed Apr 4, 2023

View reviewed changes

jdk/test/java/security/SignedJar/spi-calendar-provider/TestSPISigned.java Outdated Show resolved Hide resolved

jdk/test/java/security/SignedJar/spi-calendar-provider/TestSPISigned.java Show resolved Hide resolved

Remove erroneous java.home in ext dirs property

203a9ef

gnu-andrew approved these changes May 25, 2023

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label May 25, 2023

openjdk bot closed this May 25, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8298108: Add a regression test for JDK-8297684 #269

8298108: Add a regression test for JDK-8297684 #269

jerboaa commented Feb 27, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Feb 27, 2023

openjdk bot commented Feb 27, 2023

mlbridge bot commented Feb 27, 2023 •

edited

Loading

phohensee left a comment

openjdk bot commented Mar 1, 2023 •

edited

Loading

jerboaa commented Mar 3, 2023

bridgekeeper bot commented Mar 31, 2023

jerboaa commented Apr 3, 2023

gnu-andrew left a comment

gnu-andrew commented Apr 4, 2023 •

edited

Loading

jerboaa commented Apr 4, 2023

openjdk bot commented Apr 4, 2023

jerboaa commented Apr 4, 2023

jerboaa commented Apr 4, 2023

jerboaa commented Apr 19, 2023

bridgekeeper bot commented May 17, 2023

jerboaa commented May 19, 2023

gnu-andrew left a comment

jerboaa commented May 25, 2023

openjdk bot commented May 25, 2023

openjdk bot commented May 25, 2023

8298108: Add a regression test for JDK-8297684 #269

8298108: Add a regression test for JDK-8297684 #269

Conversation

jerboaa commented Feb 27, 2023 • edited by openjdk bot Loading

Progress

Issues

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Feb 27, 2023

openjdk bot commented Feb 27, 2023

mlbridge bot commented Feb 27, 2023 • edited Loading

Webrevs

phohensee left a comment

Choose a reason for hiding this comment

openjdk bot commented Mar 1, 2023 • edited Loading

jerboaa commented Mar 3, 2023

bridgekeeper bot commented Mar 31, 2023

jerboaa commented Apr 3, 2023

gnu-andrew left a comment

Choose a reason for hiding this comment

gnu-andrew commented Apr 4, 2023 • edited Loading

jerboaa commented Apr 4, 2023

openjdk bot commented Apr 4, 2023

jerboaa commented Apr 4, 2023

jerboaa commented Apr 4, 2023

jerboaa commented Apr 19, 2023

bridgekeeper bot commented May 17, 2023

jerboaa commented May 19, 2023

gnu-andrew left a comment

Choose a reason for hiding this comment

jerboaa commented May 25, 2023

openjdk bot commented May 25, 2023

openjdk bot commented May 25, 2023

jerboaa commented Feb 27, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Feb 27, 2023 •

edited

Loading

openjdk bot commented Mar 1, 2023 •

edited

Loading

gnu-andrew commented Apr 4, 2023 •

edited

Loading