Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8245654: Add Certigna Root CA #272

Closed

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Feb 28, 2023

Clean backport modulo path changes. Parity with Oracle JDK 8u371.

Testing:

Thoughts?


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/272/head:pull/272
$ git checkout pull/272

Update a local copy of the PR:
$ git checkout pull/272
$ git pull https://git.openjdk.org/jdk8u-dev pull/272/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 272

View PR using the GUI difftool:
$ git pr show -t 272

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/272.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2023

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c8ee076241cc7d83f423683d97ec37f9e0d6ebaa 8245654: Add Certigna Root CA Feb 28, 2023
@openjdk
Copy link

openjdk bot commented Feb 28, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 28, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2023

Webrevs

@gnu-andrew
Copy link
Member

Can you file this one against https://github.com/openjdk/jdk8u instead, so we can get it into the 8u372 release? I'm about to switch 8u-dev to 8u382 (development finished on Friday) and I'll approve there?

@jerboaa
Copy link
Contributor Author

jerboaa commented Mar 3, 2023

Can you file this one against https://github.com/openjdk/jdk8u instead, so we can get it into the 8u372 release? I'm about to switch 8u-dev to 8u382 (development finished on Friday) and I'll approve there?

@gnu-andrew Sounds good to me. I'll move test fixes #271 and #270 there as well.

@jerboaa jerboaa closed this Mar 3, 2023
@jerboaa
Copy link
Contributor Author

jerboaa commented Mar 3, 2023

jdk8u PR is here: openjdk/jdk8u#36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants