Skip to content

Conversation

@dongbohe
Copy link
Member

@dongbohe dongbohe commented Apr 1, 2022

Hi,

I would like to backport this patch to fix a typo in a suggested library name.
I updated DATE_WHEN_GENERATED with date +%s, and other parts are clean.

Testing: worked correctly after patch.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8170530: bash configure output contains a typo in a suggested library name

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/28/head:pull/28
$ git checkout pull/28

Update a local copy of the PR:
$ git checkout pull/28
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/28/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28

View PR using the GUI difftool:
$ git pr show -t 28

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/28.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 1, 2022

👋 Welcome back dongbohe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5c5ffe13e3dced0962ce2b137c1c3b30f2f3a924 8170530: bash configure output contains a typo in a suggested library name Apr 1, 2022
@openjdk
Copy link

openjdk bot commented Apr 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Apr 1, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 1, 2022

Webrevs

@dongbohe
Copy link
Member Author

ping...

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. generated-configure.sh needs to be re-generated with autogen.sh, though.

@openjdk
Copy link

openjdk bot commented Apr 22, 2022

@dongbohe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8170530: bash configure output contains a typo in a suggested library name

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 22, 2022
@dongbohe
Copy link
Member Author

Thanks Severin, Tagged the JBS issue with jdk8u-fix-request.

@dongbohe
Copy link
Member Author

Got the push approval.
/integrate

@RealFYang
Copy link
Member

/sponsor

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 10, 2022
@openjdk
Copy link

openjdk bot commented May 10, 2022

@dongbohe
Your change (at version 1d2d1bd) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented May 10, 2022

Going to push as commit 1b3e8ea.
Since your change was applied there have been 39 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 10, 2022
@openjdk openjdk bot closed this May 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 10, 2022
@openjdk
Copy link

openjdk bot commented May 10, 2022

@RealFYang @dongbohe Pushed as commit 1b3e8ea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants