Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8303828: Fix for build break on Solaris due to missing class #280

Closed

Conversation

adamfarley
Copy link
Contributor

@adamfarley adamfarley commented Mar 8, 2023

Because Solaris currently lacks this class, the build breaks when compiling Metrics.java. Inserting a dummy class to fix that.

This takes the same approach as JDK-8303408, only on Solaris.

This change is being proposed directly to JDK8u because I'm not aware of Solaris platform support post-JDK8.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8303828

Issue

  • JDK-8303828: [Solaris] Broken jdk8u build after JDK-8266391 ⚠️ Title mismatch between PR and JBS.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/280/head:pull/280
$ git checkout pull/280

Update a local copy of the PR:
$ git checkout pull/280
$ git pull https://git.openjdk.org/jdk8u-dev pull/280/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 280

View PR using the GUI difftool:
$ git pr show -t 280

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/280.diff

Because Solaris currently lacks this class, the build breaks
when compiling Metrics.java. Inserting a dummy class to fix that.

Signed-off-by: Adam Farley <adfarley@redhat.com>
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 8, 2023

👋 Welcome back afarley! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 8, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 8, 2023

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Mar 8, 2023

@adamfarley I think this fix warrants getting included in the 8u372 release as we did with JDK-8303408. Please propose a PR here instead: https://github.com/openjdk/jdk8u Thanks!

@adamfarley
Copy link
Contributor Author

Good idea Severin. PR created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants