Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282600: SSLSocketImpl should not use user_canceled workaround when not necessary #284

Closed

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Mar 14, 2023

Backport from jdk11u-dev fixing SSLSocket, not to use workaround with user_canceled alert for TLS 1.3 close, when not necessary, as it causes problems with gnutls client.

Testing:
jdk_security OK (no regressions to master).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282600: SSLSocketImpl should not use user_canceled workaround when not necessary

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/284/head:pull/284
$ git checkout pull/284

Update a local copy of the PR:
$ git checkout pull/284
$ git pull https://git.openjdk.org/jdk8u-dev pull/284/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 284

View PR using the GUI difftool:
$ git pr show -t 284

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/284.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 14, 2023

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e80528bf2bd1c87fc1394dd32015281ac6652363 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary Mar 14, 2023
@openjdk
Copy link

openjdk bot commented Mar 14, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 14, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 14, 2023

Webrevs

@zzambers
Copy link
Contributor Author

/clean

@openjdk openjdk bot added the clean label Mar 14, 2023
@openjdk
Copy link

openjdk bot commented Mar 14, 2023

@zzambers This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Mar 14, 2023

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8282600: SSLSocketImpl should not use user_canceled workaround when not necessary

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 14, 2023
@zzambers
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 14, 2023

Going to push as commit d6f8151.
Since your change was applied there has been 1 commit pushed to the master branch:

  • a7fb08c: 8293815: P11PSSSignature.engineUpdate should not print debug messages during normal operation

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 14, 2023
@openjdk openjdk bot closed this Mar 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 14, 2023
@openjdk
Copy link

openjdk bot commented Mar 14, 2023

@zzambers Pushed as commit d6f8151.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant