Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. #285

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ktakakuri
Copy link
Contributor

@ktakakuri ktakakuri commented Mar 15, 2023

This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.

Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577.
The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u.
So, I propose to judge the buttonModel is an instance of DefaultButtonModel.

Testing:
java/awt
javax/swing
ButtonGroupLayoutTraversalTest.java
bug8033699.java
DefaultButtonModelCrashTest.java
on Windows x86_64


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8154043 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request matching fixVersion openjdk8u432 to be approved (needs to be created)
  • JDK-8182577 needs maintainer approval

Issues

  • JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. (Bug - P3 - Rejected)
  • JDK-8182577: Exception when Tab key moves focus to a JCheckbox with a custom ButtonModel (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/285/head:pull/285
$ git checkout pull/285

Update a local copy of the PR:
$ git checkout pull/285
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/285/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 285

View PR using the GUI difftool:
$ git pr show -t 285

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/285.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 15, 2023

👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8d81ec63b2bafc431cbb8572a3e45e76580ab46f 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. Mar 15, 2023
@openjdk
Copy link

openjdk bot commented Mar 15, 2023

This backport pull request has now been updated with issue from the original commit.

@ktakakuri
Copy link
Contributor Author

Could someone please review this backport?

@ktakakuri
Copy link
Contributor Author

@mrserb
I issued this PR in relation to #212.
Could you please review this backport?

@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2023

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@ktakakuri
Copy link
Contributor Author

Could someone please review this backport?

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 13, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 13, 2023

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2023

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright date updates should be taken from the original commit rather than use the current year. If the existing file has a later copyright date than the file in the original commit, leave the copyright date alone. Other than that, lgtm.

@mrserb
Copy link
Member

mrserb commented Aug 10, 2023

Sorry I did not have a time to look at this PR, will try to look soon.

@ktakakuri
Copy link
Contributor Author

I corrected the copyright date.

@openjdk
Copy link

openjdk bot commented Sep 7, 2023

@ktakakuri This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 7, 2023
@openjdk
Copy link

openjdk bot commented Sep 28, 2023

⚠️ @ktakakuri This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval and removed ready Pull request is ready to be integrated labels Sep 28, 2023
@jerboaa
Copy link
Contributor

jerboaa commented Oct 11, 2023

As this fix includes the test from JDK-8182577, please use /isssue add JDK-8182577.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2023

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2023

@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Dec 6, 2023
@ktakakuri
Copy link
Contributor Author

/open

@openjdk openjdk bot reopened this Dec 12, 2023
@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@ktakakuri This pull request is now open

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2024

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member

mrserb commented Jan 9, 2024

keep open

@jerboaa
Copy link
Contributor

jerboaa commented Jan 9, 2024

As this fix includes the test from JDK-8182577, please use /isssue add JDK-8182577.

Still relevant.

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 6, 2024

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 5, 2024

@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Mar 5, 2024
@ktakakuri
Copy link
Contributor Author

/open

@openjdk openjdk bot reopened this Apr 2, 2024
@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@ktakakuri This pull request is now open

@ktakakuri
Copy link
Contributor Author

/isssue add JDK-8182577

@openjdk
Copy link

openjdk bot commented Apr 8, 2024

@ktakakuri Unknown command isssue - for a list of valid commands use /help.

@jerboaa
Copy link
Contributor

jerboaa commented Apr 8, 2024

My bad /issue add JDK-8182577

@ktakakuri
Copy link
Contributor Author

/issue add JDK-8182577

@openjdk
Copy link

openjdk bot commented Apr 10, 2024

@ktakakuri
Adding additional issue to issue list: 8182577: Exception when Tab key moves focus to a JCheckbox with a custom ButtonModel.

@openjdk
Copy link

openjdk bot commented Apr 10, 2024

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Apr 10, 2024
@ktakakuri
Copy link
Contributor Author

@phohensee
Is it OK to request a fix request?

@bridgekeeper
Copy link

bridgekeeper bot commented May 21, 2024

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk openjdk bot removed the approval label Jun 6, 2024
@ktakakuri
Copy link
Contributor Author

@theRealAph
What is the reason for fix-no?
What should I do next?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport csr Pull request needs approved CSR before integration rfr Pull request is ready for review
4 participants