Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293232: Fix race condition in pkcs11 SessionManager #288

Closed
wants to merge 1 commit into from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Mar 15, 2023

Backport from jdk11u-dev - fix for race condition in pkcs11 SessionManager.

Clean except for copyright date.

Testing:
jdk_security OK (no regressions to master).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293232: Fix race condition in pkcs11 SessionManager

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/288/head:pull/288
$ git checkout pull/288

Update a local copy of the PR:
$ git checkout pull/288
$ git pull https://git.openjdk.org/jdk8u-dev pull/288/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 288

View PR using the GUI difftool:
$ git pr show -t 288

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/288.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 15, 2023

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 939741c0a0a4a5ce2c68d14b15e1f42563bc653d 8293232: Fix race condition in pkcs11 SessionManager Mar 15, 2023
@openjdk
Copy link

openjdk bot commented Mar 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 15, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 15, 2023

Webrevs

@phohensee
Copy link
Member

/clean

The MacOS pre-submit failures look to be an unrelated infrastructure issue.

@openjdk openjdk bot added the clean label Mar 15, 2023
@openjdk
Copy link

openjdk bot commented Mar 15, 2023

@phohensee This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Mar 15, 2023

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8293232: Fix race condition in pkcs11 SessionManager

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 15, 2023
@zzambers
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 21, 2023

Going to push as commit ad41d90.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 21, 2023
@openjdk openjdk bot closed this Mar 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 21, 2023
@openjdk
Copy link

openjdk bot commented Mar 21, 2023

@zzambers Pushed as commit ad41d90.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants