Skip to content

Conversation

@sunny868
Copy link

@sunny868 sunny868 commented Mar 16, 2023

Backport from https://hg.openjdk.org/jdk9/jdk9/hotspot/rev/51b82a72aafb


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8048076: [TESTBUG] runtime/Unsafe/RangeCheck.java fails with -Xcomp

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/289/head:pull/289
$ git checkout pull/289

Update a local copy of the PR:
$ git checkout pull/289
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/289/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 289

View PR using the GUI difftool:
$ git pr show -t 289

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/289.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 16, 2023

👋 Welcome back sunny868! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 16, 2023

@sunny868 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@sunny868 sunny868 changed the title Backport 51b82a72aafb Backport 30b9c7d9cb93e650177421c667760b91ba566103 Mar 16, 2023
@openjdk openjdk bot changed the title Backport 30b9c7d9cb93e650177421c667760b91ba566103 8048076: [TESTBUG] runtime/Unsafe/RangeCheck.java fails with -Xcomp Mar 16, 2023
@openjdk
Copy link

openjdk bot commented Mar 16, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 16, 2023
@openjdk
Copy link

openjdk bot commented Mar 16, 2023

⚠️ @sunny868 the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout mydev
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Mar 16, 2023

@sunny868 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8048076: [TESTBUG] runtime/Unsafe/RangeCheck.java fails with -Xcomp

Compiler intrinsics doesn't have this assert, disabled the intrinsics to make sure we go through the VM

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • cd40350: Merge
  • 89aeae1: 8304053: Revert os specific stubs for SystemMetrics
  • ebbd3a8: 8303828: [Solaris] Broken jdk8u build after JDK-8266391
  • 5dc33f2: 8295530: Update Zlib Data Compression Library to Version 1.2.13
  • ca1c3b1: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message
  • de0e5a2: 8152432: Implement setting jtreg @requires properties vm.flavor, vm.bits, vm.compMode
  • ae6405f: 8289301: P11Cipher should not throw out of bounds exception during padding
  • ad41d90: 8293232: Fix race condition in pkcs11 SessionManager

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 16, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 16, 2023

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2023

@sunny868 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented May 30, 2023

@sunny868 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant