-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key #296
Conversation
👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport looks clean to me (patch shuffling is allowed, and it should be possibly to automate it)
Please flag the bug with jdk8u-fix-request
for approval
@alexeybakhtin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alexeybakhtin ,
Thanks for proposing this backport. Looks good to me too.
/integrate |
Going to push as commit d41618f. |
@alexeybakhtin Pushed as commit d41618f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Almost clean backport of JDK-8271199 from JDK11 patch. Only location of the files is changed
sun/security/rsa tests are passed
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/296/head:pull/296
$ git checkout pull/296
Update a local copy of the PR:
$ git checkout pull/296
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/296/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 296
View PR using the GUI difftool:
$ git pr show -t 296
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/296.diff
Webrev
Link to Webrev Comment