8253424: Add support for running pre-submit testing using GitHub Actions #3

gnu-andrew · 2022-03-05T17:05:04Z

Initial attempt to backport openjdk/jdk11u-dev@1faefed

Changes so far:

make/autoconf/version-numbers -> common/autoconf/version-numbers
Fix version variables (JDK_MAJOR_VERSION, JDK_MINOR_VERSION and JDK_MICRO_VERSION in 8u)
Remove boot JDK for Linux (provided by build environment Ubuntu 20.04 in openjdk-8-jdk)
Replace --with-version-opt with --with-user-release-suffix
Drop --enable-jtreg-failure-handler (unsupported)
Move make targets to make invocation (--with-default-make-target not supported)
Drop --with-msvc-toolset-version
Disable tests as we don't currently have the bundles required to support them

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issues

JDK-8253424: Add support for running pre-submit testing using GitHub Actions
JDK-8253865: Pre-submit testing using GitHub Actions does not detect failures reliably
JDK-8254054: Pre-submit testing using GitHub Actions should not use the deprecated set-env command
JDK-8254173: Add Zero, Minimal hotspot targets to submit workflow
JDK-8254175: Build no-pch configuration in debug mode for submit checks
JDK-8254282: Add Linux x86_32 builds to submit workflow
JDK-8255373: Submit workflow artifact name is always "test-results_.zip"
JDK-8255895: Submit workflow artifacts miss hs_errs/replays due to ZIP include mismatch
JDK-8256127: Add cross-compiled foreign architectures builds to submit workflow
JDK-8256277: Github Action build on macOS should define OS and Xcode versions
JDK-8256354: Github Action build on Windows should define OS and MSVC versions
JDK-8256414: add optimized build to submit workflow
JDK-8256393: Github Actions build on Linux should define OS and GCC versions
JDK-8256747: GitHub Actions: decouple the hotspot build-only jobs from Linux x64 testing
JDK-8257056: Submit workflow should apt-get update to avoid package installation errors
JDK-8259924: GitHub actions fail on Linux x86_32 with "Could not configure libc6:i386"
JDK-8260460: GitHub actions still fail on Linux x86_32 with "Could not configure libc6:i386"
JDK-8263667: Avoid running GitHub actions on branches named pr/*
JDK-8255305: Add Linux x86_32 tier1 to submit workflow
JDK-8255352: Archive important test outputs in submit workflow
JDK-8282225: GHA: Allow one concurrent run per PR only

Reviewers

Severin Gehwolf (@jerboaa - Reviewer)

Contributors

Alex Kasko <akasko@openjdk.org>
Zdeněk Žamberský <zzambers@redhat.com>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/3/head:pull/3
$ git checkout pull/3

Update a local copy of the PR:
$ git checkout pull/3
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/3/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3

View PR using the GUI difftool:
$ git pr show -t 3

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/3.diff

bridgekeeper · 2022-03-05T17:05:18Z

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-03-05T17:06:39Z

This backport pull request has now been updated with issues from the original commit.

mlbridge · 2022-03-05T17:11:32Z

Webrevs

…able-jtreg-failure-handler and move make targets to make command

…ssing dependency for x86 build, turn on verbose logging for x64

…uild bundle" This reverts commit ad22b98.

jerboaa · 2022-03-07T09:03:10Z

@gnu-andrew Could you mark this PR as draft until it's ready for review, please? This avoids many emails sent to the list unnecessarily.

gnu-andrew · 2022-03-07T13:38:35Z

@gnu-andrew Could you mark this PR as draft until it's ready for review, please? This avoids many emails sent to the list unnecessarily.

Done. Sorry, I didn't realise it wasn't spamming anyone.

I've done as much as I can here. I'm going to need to enlist someone to look at the Windows build. The additional builds & tests will need backports of bundle support.

jerboaa · 2022-03-08T10:05:24Z

I've done as much as I can here. I'm going to need to enlist someone to look at the Windows build. The additional builds & tests will need backports of bundle support.

Maybe @akashche or @stooke can help with the Windows GHA builds?

akashche · 2022-03-08T10:59:00Z

@jerboaa , I don't have experience with GitHub Actions, will look into them and report back.

gdams · 2022-03-09T13:48:58Z

Maybe @akashche or @stooke can help with the Windows GHA builds?

I've played around with trying to get JDK8u to compile on Windows in GH actions before, I think it mainly boils down to the version of Visual Studio on the executors. At Eclipse Adoptium we use Visual Studio 2013 but there is no easy way to install that onto the environment anymore (we used to use chocolatey but that package broke a while back). Happy to provide any help if required

gnu-andrew · 2022-03-09T16:13:04Z

Maybe @akashche or @stooke can help with the Windows GHA builds?

I've played around with trying to get JDK8u to compile on Windows in GH actions before, I think it mainly boils down to the version of Visual Studio on the executors. At Eclipse Adoptium we use Visual Studio 2013 but there is no easy way to install that onto the environment anymore (we used to use chocolatey but that package broke a while back). Happy to provide any help if required

Any help is very much welcome. I've never built on Windows before, so I have no idea of the requirements and issues there. What we have at present is pretty much what is in 11u-dev, other than I removed the --with-msvc-toolset-version option which 8u doesn't support. Maybe we have to either look into getting 8u to support newer versions of Windows or forego automated Windows testing. The former is risky, but preferable to the latter.

gnu-andrew · 2022-03-09T16:21:08Z

@jerboaa , I don't have experience with GitHub Actions, will look into them and report back.

It's largely just a collection of build scripts with interdependencies. The main part for you to look at is under windows_x64_build in https://github.com/openjdk/jdk8u-dev/pull/3/files#diff-d9aafa5b5fb68a30f87fd41d7f84a7087fd33b0b07e406fd1ba4b3e66a6b9683R756 and the configure failure in https://github.com/gnu-andrew/jdk8u-dev/runs/5442291679?check_suite_focus=true It may be that this is already familiar to you from your own builds.

…ithub.com/AdoptOpenJDK/openjdk8-upstream-binaries/pull/18/files

gdams · 2022-03-09T18:12:15Z

make/conf/test-dependencies

+JTREG_VERSION=5.1
+JTREG_BUILD=b01
+
+WINDOWS_X64_BOOT_JDK_FILENAME=openjdk-11_windows-x64_bin.zip


Suggested change

WINDOWS_X64_BOOT_JDK_FILENAME=openjdk-11_windows-x64_bin.zip

WINDOWS_X64_BOOT_JDK_FILENAME=openjdk-8_windows-x64_bin.zip

Thanks for catching this. It's only the name for the downloaded file, but it's better that the label matches what's in the box :)

gdams · 2022-03-09T18:12:24Z

make/conf/test-dependencies

+WINDOWS_X64_BOOT_JDK_URL=https://github.com/adoptium/temurin8-binaries/releases/download/jdk8u322-b06/OpenJDK8U-jdk_x64_windows_hotspot_8u322b06.zip
+WINDOWS_X64_BOOT_JDK_SHA256=c9e06afb5df850e90a4da9da31c2edf10bd6da9962c4b253e91b41237f8fb2fb
+
+MACOS_X64_BOOT_JDK_FILENAME=openjdk-11_osx-x64_bin.tar.gz


Suggested change

MACOS_X64_BOOT_JDK_FILENAME=openjdk-11_osx-x64_bin.tar.gz

MACOS_X64_BOOT_JDK_FILENAME=openjdk-8_osx-x64_bin.tar.gz

zzambers · 2022-03-09T23:44:22Z

I was doing some experiments with windows (32-bit) builds of jdk8 in github actions in the past using vs2010express. (Visual Studio 2010 is mentioned for windows in README-builds.html) When I tried my old code, and have found, that it no longer works (simple steps to install vs2010express no longer work, caused by dead MS links [1]). However, after some experimentation, I was able to install vs2010express from iso (from webarchive) and now it works again.

My basic (cleaned up) github workflow which does 32-bit build of openjdk8 using vs2010express can be found here. [2]
(feel free to use any of that code)

[1] https://github.community/t/how-to-use-vc100-for-msbuild/16623/2
[2] https://github.com/zzambers/test-jdk-builder/blob/build-ojdk8-win/.github/workflows/build-workflow.yaml

zzambers · 2022-03-10T00:04:38Z

But there is one problem, which needs to be workarounded in my setup (see that ugly sed [3] in my workflow), to get through configure, as otherwise it dies with this error (seems like problem with path conversion somewhere, but I don't remember exactly, as this is from my old code):

...
checking if fixpath can be created... no
Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 16.00.30319.01 for 80x86
Copyright (C) Microsoft Corporation.  All rights reserved.

fixpath.c
Microsoft (R) Incremental Linker Version 10.00.30319.01
Copyright (C) Microsoft Corporation.  All rights reserved.

/out:D:A:/test-jdk-builder/test-jdk-builder/jdk8u-dev/build/windows-x86-normal-server-fastdebug/fixpath.exe 
fixpath.obj 
LINK : fatal error LNK1104: cannot open file 'D:A:/test-jdk-builder/test-jdk-builder/jdk8u-dev/build/windows-x86-normal-server-fastdebug/fixpath.exe'
configure: error: Could not create /D/a/test-jdk-builder/test-jdk-builder/jdk8u-dev/build/windows-x86-normal-server-fastdebug/fixpath.exe

EDIT:
Problem is that parameter conversion, performed by msys2 on parameters, is wrong in one particular case causing configure script failure. I have found better workaround for this issue without actually modifying jdk code. But it is likely, that this issue will not affect github workflow of this project (jdk8u-dev) as it uses cygwin rather than msys2.

[3] https://github.com/zzambers/test-jdk-builder/blob/ff5f0c9662dc6829c1b267cecfdfdc74ed0af3a1/.github/workflows/build-workflow.yaml#L58
[4] zzambers/test-jdk-builder@e26f3bd

shipilev · 2022-03-10T09:07:31Z

@gnu-andrew -- please consider adding JDK-8282225 to this batch as well.

jerboaa

This seems good enough for an initial integration. Better to have some (build) tests prior integration than nothing :)

One question: Do we really need file .github/workflows/freetype.vcxproj? If not, please remove.

openjdk · 2022-04-04T08:26:27Z

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8253424: Add support for running pre-submit testing using GitHub Actions
8253865: Pre-submit testing using GitHub Actions does not detect failures reliably
8254054: Pre-submit testing using GitHub Actions should not use the deprecated set-env command
8254173: Add Zero, Minimal hotspot targets to submit workflow
8254175: Build no-pch configuration in debug mode for submit checks
8254282: Add Linux x86_32 builds to submit workflow
8255373: Submit workflow artifact name is always "test-results_.zip"
8255895: Submit workflow artifacts miss hs_errs/replays due to ZIP include mismatch
8256127: Add cross-compiled foreign architectures builds to submit workflow
8256277: Github Action build on macOS should define OS and Xcode versions
8256354: Github Action build on Windows should define OS and MSVC versions
8256414: add optimized build to submit workflow
8256393: Github Actions build on Linux should define OS and GCC versions
8256747: GitHub Actions: decouple the hotspot build-only jobs from Linux x64 testing
8257056: Submit workflow should apt-get update to avoid package installation errors
8259924: GitHub actions fail on Linux x86_32 with "Could not configure libc6:i386"
8260460: GitHub actions still fail on Linux x86_32 with "Could not configure libc6:i386"
8263667: Avoid running GitHub actions on branches named pr/*
8255305: Add Linux x86_32 tier1 to submit workflow
8255352: Archive important test outputs in submit workflow
8282225: GHA: Allow one concurrent run per PR only

Co-authored-by: Alex Kasko <akasko@openjdk.org>
Co-authored-by: Zdeněk Žamberský <zzambers@redhat.com>
Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

c5ca29f: 8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale
e403fd5: 8274751: Drag And Drop hangs on Windows
f8a6695: 8274658: ISO 4217 Amendment 170 Update
57d8d29: 8132256: jaxp: Investigate removal of com/sun/org/apache/bcel/internal/util/ClassPath.java
bb69732: 8129572: Cleanup usage of getResourceAsStream in jaxp
969f31e: Merge
0183285: Added tag jdk8u332-b05 for changeset 2a92df021686
3a7c382: 8041523: Xerces Update: Serializer improvements from Xalan
2bbec15: 8230865: [TESTBUG] jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target
25693fa: 8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp
... and 3 more: https://git.openjdk.java.net/jdk8u-dev/compare/6f01b5341956285a9f246a9228586d8c000603dc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

gnu-andrew · 2022-04-04T12:35:53Z

This seems good enough for an initial integration. Better to have some (build) tests prior integration than nothing :)

One question: Do we really need file .github/workflows/freetype.vcxproj? If not, please remove.

It was provided by Alex for the Windows build: #3 (comment)

I'm no expert as to why this is needed. I did notice there were some FreeType build changes that could possibly be backported. I'd rather we did this in a follow-on PR though, so we can get the basics in. It's already been a month, and personally, I'm not going to have time to look at anything for the next few weeks, due to the security update.

jerboaa · 2022-04-04T13:08:36Z

This seems good enough for an initial integration. Better to have some (build) tests prior integration than nothing :)
One question: Do we really need file .github/workflows/freetype.vcxproj? If not, please remove.

It was provided by Alex for the Windows build: #3 (comment)

OK. No expert on this either, so fine with me going in either way :-) It's certainly better than what we have currently.

akashche · 2022-04-04T15:08:26Z

This seems good enough for an initial integration. Better to have some (build) tests prior integration than nothing :)
One question: Do we really need file .github/workflows/freetype.vcxproj? If not, please remove.

It was provided by Alex for the Windows build: #3 (comment)

OK. No expert on this either, so fine with me going in either way :-) It's certainly better than what we have currently.

This freetype.vcxproj file is used to replace the default FreeType build file. It has modifications to be buildable with VS2017. It is necessary for --with-freetype-src to work, with this flag FreeType is being built with msbuild (that used this build file) at configure time. We can avoid it by building FreeType by some other means (before running configure) and using --with-freetype-lib and --with-freetype-include instead. Just this --with-freetype-src seems to be "the most vanilla" way to build FreeType for 8u, so I suggest to continue using it.

gnu-andrew · 2022-04-05T21:15:31Z

This seems good enough for an initial integration. Better to have some (build) tests prior integration than nothing :)
One question: Do we really need file .github/workflows/freetype.vcxproj? If not, please remove.

It was provided by Alex for the Windows build: #3 (comment)

OK. No expert on this either, so fine with me going in either way :-) It's certainly better than what we have currently.

Thanks. I've flagged the main bug for 8u approval now (I presume we can infer the others from that one).

gnu-andrew · 2022-04-05T21:17:14Z

This seems good enough for an initial integration. Better to have some (build) tests prior integration than nothing :)
One question: Do we really need file .github/workflows/freetype.vcxproj? If not, please remove.

It was provided by Alex for the Windows build: #3 (comment)

OK. No expert on this either, so fine with me going in either way :-) It's certainly better than what we have currently.

This freetype.vcxproj file is used to replace the default FreeType build file. It has modifications to be buildable with VS2017. It is necessary for --with-freetype-src to work, with this flag FreeType is being built with msbuild (that used this build file) at configure time. We can avoid it by building FreeType by some other means (before running configure) and using --with-freetype-lib and --with-freetype-include instead. Just this --with-freetype-src seems to be "the most vanilla" way to build FreeType for 8u, so I suggest to continue using it.

Thanks for the explanation. That does make things a lot clearer for me.

A couple of questions:

Does this mean the file is not needed for the VS2010 build? I duplicated your changes in that build and it seems to work at present.
Any idea why 11u (which this is backported from) works without this? Does it build FreeType in a different way?

akashche · 2022-04-05T21:51:07Z

A couple of questions:

Does this mean the file is not needed for the VS2010 build? I duplicated your changes in that build and it seems to work at present.

Yes, I believe it is not needed for VS2010. I haven't tried it with 32-bit VS2010 myself, but IIRC it worked out of the box with 64-bit VS2013 (freeware version of VS2010 doesn't support 64-bit, setup is possible with WinSDK7.1 toolchain, but it is complicated). Modified file was intended to change only 64-bit config (to make it working with 64-bit VS2017) so 32-bit config remained the same there. Thus Copy FreeType project file step on 32-bit most probably can be removed.

Any idea why 11u (which this is backported from) works without this? Does it build FreeType in a different way?

Yes, in 8u FreeType is not included in-tree, it was always used as an external dependency and for "open" jdk only (Oracle JDK didn't use it). --with-freetype-src flag is relatively recent, it was added in JDK-8057538. In 11u FreeType is included in-tree and is built the same way as other in-tree dep libs.

gnu-andrew · 2022-04-06T19:45:09Z

I see the bug now has jdk8u-fix-yes.

gnu-andrew · 2022-04-06T19:46:21Z

A couple of questions:

Does this mean the file is not needed for the VS2010 build? I duplicated your changes in that build and it seems to work at present.

Yes, I believe it is not needed for VS2010. I haven't tried it with 32-bit VS2010 myself, but IIRC it worked out of the box with 64-bit VS2013 (freeware version of VS2010 doesn't support 64-bit, setup is possible with WinSDK7.1 toolchain, but it is complicated). Modified file was intended to change only 64-bit config (to make it working with 64-bit VS2017) so 32-bit config remained the same there. Thus Copy FreeType project file step on 32-bit most probably can be removed.

Thanks. We can maybe try that in a follow-up PR.

Any idea why 11u (which this is backported from) works without this? Does it build FreeType in a different way?

Yes, in 8u FreeType is not included in-tree, it was always used as an external dependency and for "open" jdk only (Oracle JDK didn't use it). --with-freetype-src flag is relatively recent, it was added in JDK-8057538. In 11u FreeType is included in-tree and is built the same way as other in-tree dep libs.

Interesting, thanks. It may be worth considering whether to bring the FreeType sources into 8u as well.

gnu-andrew · 2022-04-06T19:46:31Z

/integrate

openjdk · 2022-04-06T19:47:30Z

Going to push as commit 10029f7.
Since your change was applied there have been 14 commits pushed to the master branch:

62bbb3e: 8281814: Debuginfo.diz contains redundant build path after backport JDK-8025936
c5ca29f: 8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale
e403fd5: 8274751: Drag And Drop hangs on Windows
f8a6695: 8274658: ISO 4217 Amendment 170 Update
57d8d29: 8132256: jaxp: Investigate removal of com/sun/org/apache/bcel/internal/util/ClassPath.java
bb69732: 8129572: Cleanup usage of getResourceAsStream in jaxp
969f31e: Merge
0183285: Added tag jdk8u332-b05 for changeset 2a92df021686
3a7c382: 8041523: Xerces Update: Serializer improvements from Xalan
2bbec15: 8230865: [TESTBUG] jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target
... and 4 more: https://git.openjdk.java.net/jdk8u-dev/compare/6f01b5341956285a9f246a9228586d8c000603dc...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-04-06T19:47:46Z

@gnu-andrew Pushed as commit 10029f7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

gdams · 2022-07-13T11:15:21Z

Interesting, thanks. It may be worth considering whether to bring the FreeType sources into 8u as well.

@gnu-andrew I'm currently on a backport of openjdk/jdk11u@58ff4ee to JDK8u. If I can get it to work I'll submit a backport PR here for review. It should make the FreeType maintenance easier going forwards and should allow us to progress from 2.8.x which has some published vulnerabilities.

Backport 1faefed218051c324bdb5c7c10369050d6c9dd44

61cd916

openjdk bot changed the title ~~Backport 1faefed218051c324bdb5c7c10369050d6c9dd44~~ 8253424: Add support for running pre-submit testing using GitHub Actions Mar 5, 2022

openjdk bot added backport rfr Pull request is ready for review labels Mar 5, 2022

gnu-andrew added 7 commits March 5, 2022 17:20

Replace --with-version-opt with --with-user-release-suffix, drop --en…

39c5d9a

…able-jtreg-failure-handler and move make targets to make command

Replace --with-version-build with --with-build-number

13d9442

Replace product-bundles and test-bundles targets with images

e0bf82c

Disable tests, remove unsupported --with-msvc-toolset-version, add mi…

12fe949

…ssing dependency for x86 build, turn on verbose logging for x64

Switch Linux builds to use bundled zlib

f1aa163

Disable additional Linux builds which depend on first Linux build bundle

ad22b98

Revert "Disable additional Linux builds which depend on first Linux b…

c5015f5

…uild bundle" This reverts commit ad22b98.

gnu-andrew marked this pull request as draft March 7, 2022 13:37

openjdk bot removed the rfr Pull request is ready for review label Mar 7, 2022

gnu-andrew added 2 commits March 9, 2022 16:51

Try permissions fix for Windows suggested by Simon Tooke in https://g…

7d26551

…ithub.com/AdoptOpenJDK/openjdk8-upstream-binaries/pull/18/files

Add missing semi-colon

ee7ab5a

gdams reviewed Mar 9, 2022

View reviewed changes

gnu-andrew added 8 commits March 19, 2022 19:02

Try to fix quoting and dependencies

f2fc1c4

windows-2016 dropped on 2022-03-15. Search for config.log first

e78b0e4

Build number should be of the format "bxx" in OpenJDK 8u

c31ac2f

Use env.HOME instead of github.workspace

dacb99f

Use %HOMEPATH% rather than env.HOME

803182e

Try relative path for VS2010

fa003b1

Try using PowerShell for VS2010 install

3cd2d76

User Start-Process to run setup.exe

cae7190

gnu-andrew marked this pull request as ready for review April 3, 2022 22:14

openjdk bot added the rfr Pull request is ready for review label Apr 3, 2022

jerboaa approved these changes Apr 4, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 4, 2022

openjdk bot added the integrated Pull request has been integrated label Apr 6, 2022

openjdk bot closed this Apr 6, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 6, 2022

gdams mentioned this pull request Nov 8, 2022

Include freetype source from openjdk ibmruntimes/openj9-openjdk-jdk8#631

Merged

8253424: Add support for running pre-submit testing using GitHub Actions #3

8253424: Add support for running pre-submit testing using GitHub Actions #3

gnu-andrew commented Mar 5, 2022 •

edited by openjdk bot

bridgekeeper bot commented Mar 5, 2022

openjdk bot commented Mar 5, 2022

mlbridge bot commented Mar 5, 2022 •

edited

jerboaa commented Mar 7, 2022

gnu-andrew commented Mar 7, 2022

jerboaa commented Mar 8, 2022

akashche commented Mar 8, 2022

gdams commented Mar 9, 2022

gnu-andrew commented Mar 9, 2022

gnu-andrew commented Mar 9, 2022

gdams Mar 9, 2022

gnu-andrew Mar 10, 2022

gdams Mar 9, 2022

zzambers commented Mar 9, 2022

zzambers commented Mar 10, 2022 •

edited

shipilev commented Mar 10, 2022

jerboaa left a comment

openjdk bot commented Apr 4, 2022 •

edited

gnu-andrew commented Apr 4, 2022

jerboaa commented Apr 4, 2022

akashche commented Apr 4, 2022

gnu-andrew commented Apr 5, 2022

gnu-andrew commented Apr 5, 2022

akashche commented Apr 5, 2022

gnu-andrew commented Apr 6, 2022

gnu-andrew commented Apr 6, 2022

gnu-andrew commented Apr 6, 2022

openjdk bot commented Apr 6, 2022

openjdk bot commented Apr 6, 2022

gdams commented Jul 13, 2022 •

edited

	WINDOWS_X64_BOOT_JDK_FILENAME=openjdk-11_windows-x64_bin.zip
	WINDOWS_X64_BOOT_JDK_FILENAME=openjdk-8_windows-x64_bin.zip

	MACOS_X64_BOOT_JDK_FILENAME=openjdk-11_osx-x64_bin.tar.gz
	MACOS_X64_BOOT_JDK_FILENAME=openjdk-8_osx-x64_bin.tar.gz

8253424: Add support for running pre-submit testing using GitHub Actions #3

8253424: Add support for running pre-submit testing using GitHub Actions #3

Conversation

gnu-andrew commented Mar 5, 2022 • edited by openjdk bot

Progress

Issues

Reviewers

Contributors

Reviewing

bridgekeeper bot commented Mar 5, 2022

openjdk bot commented Mar 5, 2022

mlbridge bot commented Mar 5, 2022 • edited

Webrevs

jerboaa commented Mar 7, 2022

gnu-andrew commented Mar 7, 2022

jerboaa commented Mar 8, 2022

akashche commented Mar 8, 2022

gdams commented Mar 9, 2022

gnu-andrew commented Mar 9, 2022

gnu-andrew commented Mar 9, 2022

gdams Mar 9, 2022

Choose a reason for hiding this comment

gnu-andrew Mar 10, 2022

Choose a reason for hiding this comment

gdams Mar 9, 2022

Choose a reason for hiding this comment

zzambers commented Mar 9, 2022

zzambers commented Mar 10, 2022 • edited

shipilev commented Mar 10, 2022

jerboaa left a comment

Choose a reason for hiding this comment

openjdk bot commented Apr 4, 2022 • edited

gnu-andrew commented Apr 4, 2022

jerboaa commented Apr 4, 2022

akashche commented Apr 4, 2022

gnu-andrew commented Apr 5, 2022

gnu-andrew commented Apr 5, 2022

akashche commented Apr 5, 2022

gnu-andrew commented Apr 6, 2022

gnu-andrew commented Apr 6, 2022

gnu-andrew commented Apr 6, 2022

openjdk bot commented Apr 6, 2022

openjdk bot commented Apr 6, 2022

gdams commented Jul 13, 2022 • edited

gnu-andrew commented Mar 5, 2022 •

edited by openjdk bot

mlbridge bot commented Mar 5, 2022 •

edited

zzambers commented Mar 10, 2022 •

edited

openjdk bot commented Apr 4, 2022 •

edited

gdams commented Jul 13, 2022 •

edited