-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8277881: Missing SessionID in TLS1.3 resumption in compatibility mode #300
Conversation
👋 Welcome back lutkerd! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/clean |
@phohensee This backport pull request is now marked as clean |
@lutkerd This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Going to push as commit b94b568.
Your commit was automatically rebased without conflicts. |
@phohensee @lutkerd Pushed as commit b94b568. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Patch applied cleanly after updating file paths.
Backport to fix issue in TLSv1.3 Middleware compatibility and parity with Oracle 8u381. Passed Tier1/2 testing internally on Linux x64 and aarch64.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/300/head:pull/300
$ git checkout pull/300
Update a local copy of the PR:
$ git checkout pull/300
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/300/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 300
View PR using the GUI difftool:
$ git pr show -t 300
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/300.diff
Webrev
Link to Webrev Comment