8151460: Metaspace counters can have inconsistent values

[tstuefe]

To reduce intermittent errors from TestPerfCountersAndMemoryPools, I'd like to backport "8151460: Metaspace counters can have inconsistent values".

This does not backport cleanly since JEP 280 [1] modified the test, and I won't backport that one of course. Therefore I also added the test-specific fix JEP 280 did (24773b4).

Tests: I manually ran gc/metaspace jtreg tests on Linux x64 with fastdebug and release builds.

[1] https://bugs.openjdk.org/browse/JDK-8148483

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8151460: Metaspace counters can have inconsistent values

Reviewers

• Paul Hohensee (@phohensee - Reviewer) ⚠️ Review applies to e66afb55
• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/301/head:pull/301
$ git checkout pull/301

Update a local copy of the PR:
$ git checkout pull/301
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/301/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 301

View PR using the GUI difftool:
$ git pr show -t 301

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/301.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (6ff57709)
• 00: Full (e66afb55)

[phohensee]

Lgtm.

Also, please configure pre-submit testing.

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8151460: Metaspace counters can have inconsistent values

Reviewed-by: phh, sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jerboaa]

Seems fine to me.

[tstuefe]

Thanks @jerboaa and @phohensee.

GHAs ran through, including the changed tests.

/integrate

[openjdk]

Going to push as commit 43561ef.
Since your change was applied there has been 1 commit pushed to the master branch:

• 721c0ee: 8305113: (tz) Update Timezone Data to 2023c

Your commit was automatically rebased without conflicts.

[openjdk]

@tstuefe Pushed as commit 43561ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.