8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4

[benty-amzn]

Backport-of: 269eae61894b6bd0a7512045a369b53df747f6e5

Backport is not clean, because 8167295 has not been backported to jdk8u.

This fixes a bug in common network code with MacOS, and it is already fixed in all other JDK releases. See the JBS issue for more info

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4

Reviewers

• Paul Hohensee (@phohensee - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/303/head:pull/303
$ git checkout pull/303

Update a local copy of the PR:
$ git checkout pull/303
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/303/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 303

View PR using the GUI difftool:
$ git pr show -t 303

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/303.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (b944a3a1)

[phohensee]

Lgtm. Testing?

[openjdk]

@benty-amzn This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4

Reviewed-by: phh, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

• 3e69b49: 8307531: [aarch64] JDK8 single-step debugging is extremely slow
• 4328fec: 8303028: Update system property for Java SE specification maintenance version
• 3d9e8d0: 8305681: Allow additional characters for GB18030-2022 (Level 2) support
• 9740c24: 8301400: Allow additional characters for GB18030-2022 support
• 3147b1b: 8305165: [8u] ServiceThread::nmethods_do is not called to keep nmethods from being zombied while in the queue
• 7878655: Merge
• 338acde: 8305113: (tz) Update Timezone Data to 2023c
• 74148f8: 8299129: Enhance NameService lookups
• 33758ae: 8298667: Improved path handling
• 71bb00a: 8298310: Enhance TLS session negotiation
• ... and 19 more: https://git.openjdk.org/jdk8u-dev/compare/f1c1f969a77c9841cf87b2434fa90dcf4002c6be...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[benty-amzn]

All tests in jdk/test/java/nio/channels/DatagramChannel were run.
I have 3 failures:

runner finished test: java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java
Failed. Execution failed: `main’ threw exception: java.lang.RuntimeException: Expected message not recieved


runner finished test: java/nio/channels/DatagramChannel/ReceiveISA.java
Failed. Execution failed: `main’ threw exception: java.lang.Exception: Source address for packets 1 & 2 should be equal

runner finished test: java/nio/channels/DatagramChannel/ChangingAddress.java
Failed. Execution failed: `main’ threw exception: java.lang.RuntimeException: Expected: 0.0.0.0/0.0.0.0, actual: /192.168.1.240

however these tests also fail without the backport present, and I believe they are an issue with my local network or configuration unrelated to the patch.

[benty-amzn]

/integrate

[openjdk]

@benty-amzn
Your change (at version b944a3a) is now ready to be sponsored by a Committer.

[bridgekeeper]

@benty-amzn This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[shipilev]

Looks fine to me, thanks.

[shipilev]

/sponsor

[openjdk]

Going to push as commit c7c080a.
Since your change was applied there have been 29 commits pushed to the master branch:

• 3e69b49: 8307531: [aarch64] JDK8 single-step debugging is extremely slow
• 4328fec: 8303028: Update system property for Java SE specification maintenance version
• 3d9e8d0: 8305681: Allow additional characters for GB18030-2022 (Level 2) support
• 9740c24: 8301400: Allow additional characters for GB18030-2022 support
• 3147b1b: 8305165: [8u] ServiceThread::nmethods_do is not called to keep nmethods from being zombied while in the queue
• 7878655: Merge
• 338acde: 8305113: (tz) Update Timezone Data to 2023c
• 74148f8: 8299129: Enhance NameService lookups
• 33758ae: 8298667: Improved path handling
• 71bb00a: 8298310: Enhance TLS session negotiation
• ... and 19 more: https://git.openjdk.org/jdk8u-dev/compare/f1c1f969a77c9841cf87b2434fa90dcf4002c6be...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @benty-amzn Pushed as commit c7c080a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.