Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274864: Remove Amman/Cairo hacks in ZoneInfoFile #304

Closed
wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Apr 13, 2023

https://bugs.openjdk.org/browse/JDK-8305967 Remove Amman/Cairo hacks in ZoneInfoFile

Backport-of: ec199072 (cherry picked from commit b4caafe16f14983e303b7f1fdf3090e5c513ebd8 from the openjdk/jdk11u-dev repository.)

This pull request contains a backport of commit ec199072 from the openjdk/jdk repository.

The commit being backported was authored by Naoto Sato on 8 Oct 2021 and was reviewed by Iris Clark and Joe Wang.

Backport is clean. Tests in jdk/test/java/util/TimeZone jdk/test/java/time/test jdk/test/sun/util/resources jdk/test/sun/text/resources jdk/test/sun/util/calendar: Test results: passed: 123


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274864: Remove Amman/Cairo hacks in ZoneInfoFile

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/304/head:pull/304
$ git checkout pull/304

Update a local copy of the PR:
$ git checkout pull/304
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/304/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 304

View PR using the GUI difftool:
$ git pr show -t 304

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/304.diff

Webrev

Link to Webrev Comment

Backport-of: ec199072c5867624d66840238cc8828e16ae8da7
(cherry picked from commit b4caafe16f14983e303b7f1fdf3090e5c513ebd8)
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 13, 2023

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ec199072c5867624d66840238cc8828e16ae8da7 8274864: Remove Amman/Cairo hacks in ZoneInfoFile Apr 13, 2023
@openjdk
Copy link

openjdk bot commented Apr 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 13, 2023
@Rudometov
Copy link
Member Author

/clean

@mlbridge
Copy link

mlbridge bot commented Apr 13, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 13, 2023

@Rudometov Only OpenJDK Committers can use the /clean command

@gnu-andrew
Copy link
Member

8u does not have JDK-8212970 and still uses rearguard format, so I don't believe this change is safe to apply there.

@Rudometov
Copy link
Member Author

Thank you for your comment. Closing the pr.

@Rudometov Rudometov closed this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
2 participants