8159690: [TESTBUG] Mark headful tests with @key headful.

[yaqsun]

The patch is not clean because the 31 tests are omitted, and because of various context differences. The only substantive change is the addition of @headful, which doesn’t affect running any of the tests.

There are 30 tests that were in the original patch that are not present in 8u. And there is 1 test that does not need to handle headful.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8159690 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8159690: [TESTBUG] Mark headful tests with @key headful. (Bug - P4 - Approved)

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/306/head:pull/306
$ git checkout pull/306

Update a local copy of the PR:
$ git checkout pull/306
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/306/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 306

View PR using the GUI difftool:
$ git pr show -t 306

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/306.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @yaqsun, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user yaqsun" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[yaqsun]

/covered
I am a Loongson employee

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[gnu-andrew]

We did start looking at backporting this a while back (see Paul's existing backport bug)

Have you just omitted the 30 tests? We do need to check that these are not potential backports themselves before doing so, otherwise we risk the issue of bringing them in later and the @headful addition being missed.

What is the one test that doesn't need to handle @headful and why?

Is there a particular reason you need this backported? I think it was eventually dropped because it's a lot of effort for not much gain.

[yaqsun]

Yes, I omit 30 tests because they no longer exist in 8u.

There is 1 test java/awt/image/DrawImage/IncorrectUnmanagedImageSourceOffset.java that does not need to handle @headful because @headful already exist.

This backported will cause a large number of jdk/test tests to fail, interfering with regression testing.

[mlbridge]

Webrevs

• 00: Full (be2540ec)

[bridgekeeper]

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[yaqsun]

I need help with progressing this pull request towards integration.
Does patch need to break up? I look forward to the reply to the proposal of this patch.
Thanks very much!

[bridgekeeper]

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@yaqsun This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[yaqsun]

/open

[openjdk]

@yaqsun This pull request is now open

[bridgekeeper]

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[yaqsun]

/approval 8159690 request

[openjdk]

@yaqsun
8159690: The approval request has been created successfully.

[openjdk]

⚠️ @yaqsun This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mrserb]

I think we should start from something, and then fix any missing part if any.

[yaqsun]

I think we should start from something, and then fix any missing part if any.

I started by sorting fixes by test case name，eg:jdk/test/java/awt, javax/swing, sun/java2d, etc？

[mrserb]

I meant "something" - is the current patch on the review, we can integrate it as-is, and a few others currently under review. If we missed some tests then we can fix that later.

[yaqsun]

Please maintainer approval my pr.
Thank you very much.

[gnu-andrew]

I think we should start from something, and then fix any missing part if any.

I tend to agree, but we should at least know what follow-ups we want before this goes on, or they are likely to never happen. I'll try and look over this before the end of the week so we can get it in before rampdown.

[gnu-andrew]

/approval 8159690 request

A reason should be given as to why the request should be approved. See https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/approval

[gnu-andrew]

Yes, I omit 30 tests because they no longer exist in 8u.

It's more that they never did, as they were introduced in 9.

There is 1 test java/awt/image/DrawImage/IncorrectUnmanagedImageSourceOffset.java that does not need to handle @headful because @headful already exist.

Yes, I see this is covered by 8221497: Optional Panes in Swing

This backported will cause a large number of jdk/test tests to fail, interfering with regression testing.

Ok.

[gnu-andrew]

Patch looks good. Copyright headers and context is adapted where needed.
Will add a list of the missed tests to this PR and their bugs. Some may be backportable, at least the test part even if we don't make the associated code change.

[gnu-andrew]

File	Bug
test/java/awt/AppContext/ApplicationThreadsStop/ApplicationThreadsStop.java	JDK-8136858: Examine the usage of ThreadGroup.stop() in in sun.awt.AppContext
test/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.html	JDK-8014725: closed/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.html failed intermittently
test/java/awt/Cursor/GetSystemCustomCursor/GetSystemCustomCursor.java	JDK-8039269: images/cursors should not be in ${java.home}/lib - Yes for test and refactoring
test/java/awt/Debug/DumpOnKey/DumpOnKey.java	JDK-4379403: Need to disable the "magic AWT dump key" (CTRL+SHIFT+F1)
test/java/awt/EventDispatchThread/PropertyPermissionOnEDT/PropertyPermissionOnEDT.java	JDK-8080405: Exception in thread "AWT-EventQueue-1" java.security.AccessControlException
test/java/awt/FileDialog/ModalFocus/FileDialogModalFocusTest.java	JDK-8025815: Child FileDialog of modal dialog does not get focus on Gnome
test/java/awt/Focus/Cause/FocusCauseTest.java	JDK-8080395: consider making sun.awt.CausedFocusEvent functionality public
test/java/awt/Focus/FocusTraversalPolicy/ContainerOrderFTPTest.java	JDK-8025001: setFocusTraversalPolicy() to ContainerOrderFocusTraversalPolicy results in an infinite loop
test/java/awt/Frame/MaximizedToUnmaximized/MaximizedToUnmaximized.java	JDK-7124365: setMaximizedBounds() should be implemented
test/java/awt/Graphics/CopyScaledArea/CopyScaledAreaTest.java	JDK-8069348: SunGraphics2D.copyArea() does not properly work for scaled graphics in D3D
test/java/awt/List/ActionEventTest/ActionEventTest.java`	JDK-6191390: Action Event triggered by list does not reflect the modifiers properly on win32
test/java/awt/List/ItemEventTest/ItemEventTest.java`	JDK-8033936: java.awt.List events are not sent properly to handleEvent or ItemListener
test/java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersInKeyEvent.java`	JDK-8143054: [macosx] KeyEvent modifiers do not contain information about mouse buttons
test/java/awt/Mouse/MouseWheelAbsXY/MouseWheelAbsXY.java	JDK-6778087: getLocationOnScreen() always returns (0, 0)for mouse wheel events
test/java/awt/MouseInfo/PointerInfoCrashTest.java	JDK-8143316: Crash Trend in 1.9.0-ea-b93 (sun.awt.DefaultMouseInfoPeer.fillPointWithCoords)
test/java/awt/TextArea/TextAreaScrolling/TextAreaScrolling.java	JDK-6180449: Text in TextArea scrolls to its left one char when selecting the text from the end
test/java/awt/TextField/EOLTest/EOLTest.java	JDK-8055197: TextField deletes multiline strings
test/java/awt/Toolkit/GetSizeTest/GetScreenSizeTest.java	JDK-8144074: [PIT] Crash calling Toolkit.getScreenSize() on Windows
test/java/awt/Window/FindOwner/FindOwnerTest.html	JDK-8139227: Text fields in JPopupMenu structure do not receive focus in hosted Applets
test/java/awt/Window/MultiWindowApp/MultiWindowAppTest.java	JDK-8022334: After calling frame.toBack() dialog goes to the back on Ubuntu 12.04
test/java/awt/Window/ScreenLocation/ScreenLocationTest.java	JDK-8011616: JWindow.getLocation and JWindow.getLocationOnScreen return different values on Unity
test/java/awt/applet/Applet/AppletFlipBuffer.java	JDK-8130390: Applet fails to launch on virtual desktop
test/java/awt/datatransfer/ConstructFlavoredObjectTest/ConstructFlavoredObjectTest.java	JDK-8142968: Module System implementation
test/java/awt/datatransfer/DataFlavor/DataFlavorRemoteTest.java	JDK-8142968: Module System implementation
test/java/awt/hidpi/properties/HiDPIPropertiesUnixTest.java	JDK-8150844: [hidpi] [macosx] -Dsun.java2d.uiScale should be taken into account for OS X
test/java/awt/image/DrawImage/IncorrectUnmanagedImageSourceOffset.java	JDK-8029253: [macosx] Performance problems with Retina display on Mac OS X
test/java/awt/image/DrawImage/ScaledImageAlphaTest.java	JDK-8139183: drawImage misses background's alpha channel
test/java/awt/image/multiresolution/MultiresolutionIconTest.java	JDK-8150724: create a test for multiresolution icons
test/java/awt/security/WarningWindowDisposeTest/WarningWindowDisposeCrashTest.java	JDK-8041490: [macosx] Crash in system tray functionality check test
test/javax/swing/SwingUtilities/8049533/bug8049533.java	JDK-8049533: SwingUtilities.convertMouseEvent misses MouseWheelEvent.preciseWheelRotation
test/sun/java2d/SunGraphics2D/SurfaceDestination/SurfaceDestination.java	JDK-8134603: Incorrect destination is used in CGLLayer surface

[gnu-andrew]

/approve yes

[openjdk]

@gnu-andrew
8159690: The approval request has been approved.

[openjdk]

@yaqsun This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8159690: [TESTBUG] Mark headful tests with @key headful.

Reviewed-by: serb, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 161 new commits pushed to the master branch:

• 0f20f67: 8326686: Bump update version of OpenJDK: 8u422
• f05ea98: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
• a798523: 8025439: [TEST BUG] [macosx] PrintServiceLookup.lookupPrintServices doesn't work properly since jdk8b105
• 824dbfb: 8186199: [windows] JNI_DestroyJavaVM not covered by SEH
• 5e70a86: 8324530: Build error with gcc 10
• 53e0826: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
• a37b856: 8016451: Scary messages emitted by build.tools.generatenimbus.PainterGenerator during build
• b7bda28: 8325150: (tz) Update Timezone Data to 2024a
• ae516a3: 8074860: Structured Exception Catcher missing around CreateJavaVM on Windows
• 9bd600c: 8079441: Intermittent failures on Windows with "Unexpected exit from test [exit code: 1080890248]" (0x406d1388)
• ... and 151 more: https://git.openjdk.org/jdk8u-dev/compare/721c0ee3d790b7dfbaa7b1018e4921a1d4751fd2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[yaqsun]

/integrate

[openjdk]

@yaqsun
Your change (at version be2540e) is now ready to be sponsored by a Committer.

[gnu-andrew]

8u422 open for commits
/sponsor

[openjdk]

Going to push as commit d7ad5bf.
Since your change was applied there have been 162 commits pushed to the master branch:

• 0bf84a2: 8198321: javax/swing/JEditorPane/5076514/bug5076514.java fails
• 0f20f67: 8326686: Bump update version of OpenJDK: 8u422
• f05ea98: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
• a798523: 8025439: [TEST BUG] [macosx] PrintServiceLookup.lookupPrintServices doesn't work properly since jdk8b105
• 824dbfb: 8186199: [windows] JNI_DestroyJavaVM not covered by SEH
• 5e70a86: 8324530: Build error with gcc 10
• 53e0826: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
• a37b856: 8016451: Scary messages emitted by build.tools.generatenimbus.PainterGenerator during build
• b7bda28: 8325150: (tz) Update Timezone Data to 2024a
• ae516a3: 8074860: Structured Exception Catcher missing around CreateJavaVM on Windows
• ... and 152 more: https://git.openjdk.org/jdk8u-dev/compare/721c0ee3d790b7dfbaa7b1018e4921a1d4751fd2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@gnu-andrew @yaqsun Pushed as commit d7ad5bf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.