Skip to content

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Apr 21, 2023

Hi all,
This pull request contains a backport of commit 041ae20b from the openjdk/jdk repository.
The commit being backported was authored by Fernando Guallini on 7 Sep 2021 and was reviewed by Sean Mullan and Rajan Halade.
Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/308/head:pull/308
$ git checkout pull/308

Update a local copy of the PR:
$ git checkout pull/308
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/308/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 308

View PR using the GUI difftool:
$ git pr show -t 308

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/308.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 21, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 041ae20b10e11381415e8f61fd39e9e19aa8d4f2 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped Apr 21, 2023
@openjdk
Copy link

openjdk bot commented Apr 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Apr 21, 2023
@mrserb mrserb marked this pull request as ready for review April 24, 2023 20:27
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 24, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 24, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Apr 25, 2023

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 25, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2023

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member Author

mrserb commented May 23, 2023

bot, keep it open

@mrserb
Copy link
Member Author

mrserb commented May 24, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 24, 2023

Going to push as commit 8562298.
Since your change was applied there have been 6 commits pushed to the master branch:

  • c7c080a: 8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4
  • 3e69b49: 8307531: [aarch64] JDK8 single-step debugging is extremely slow
  • 4328fec: 8303028: Update system property for Java SE specification maintenance version
  • 3d9e8d0: 8305681: Allow additional characters for GB18030-2022 (Level 2) support
  • 9740c24: 8301400: Allow additional characters for GB18030-2022 support
  • 3147b1b: 8305165: [8u] ServiceThread::nmethods_do is not called to keep nmethods from being zombied while in the queue

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 24, 2023
@openjdk openjdk bot closed this May 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 24, 2023
@openjdk
Copy link

openjdk bot commented May 24, 2023

@mrserb Pushed as commit 8562298.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants