Skip to content

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented May 2, 2023

Hi all,

Clean backport for a trivial patch.

This pull request contains a backport of commit f4fa68a2 from the openjdk/jdk repository.

The commit being backported was authored by Prasanta Sadhukhan on 14 Feb 2015 and was reviewed by Phil Race and Sergey Bylokhov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8072678: Wrong exception messages in java.awt.color.ICC_ColorSpace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/309/head:pull/309
$ git checkout pull/309

Update a local copy of the PR:
$ git checkout pull/309
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/309/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 309

View PR using the GUI difftool:
$ git pr show -t 309

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/309.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f4fa68a2a795ca073409b76332037cc601e66b13 8072678: Wrong exception messages in java.awt.color.ICC_ColorSpace May 2, 2023
@openjdk
Copy link

openjdk bot commented May 2, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label May 2, 2023
@mrserb mrserb marked this pull request as ready for review May 2, 2023 21:57
@openjdk openjdk bot added the rfr Pull request is ready for review label May 2, 2023
@mlbridge
Copy link

mlbridge bot commented May 2, 2023

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented May 5, 2023

Clean backport for a trivial patch.

Confirmed clean (modulo path changes).

@jerboaa
Copy link
Contributor

jerboaa commented May 5, 2023

/clean

@openjdk openjdk bot added the clean Identical backport; no merge resolution required label May 5, 2023
@openjdk
Copy link

openjdk bot commented May 5, 2023

@jerboaa This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented May 5, 2023

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8072678: Wrong exception messages in java.awt.color.ICC_ColorSpace

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 5, 2023
@mrserb
Copy link
Member Author

mrserb commented May 25, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 25, 2023

Going to push as commit 20b4c70.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 764dbd5: 8307310: Backport the tests for JDK-8058969 and JDK-8039271 to the OpenJDK8
  • 8562298: 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped
  • c7c080a: 8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4
  • 3e69b49: 8307531: [aarch64] JDK8 single-step debugging is extremely slow
  • 4328fec: 8303028: Update system property for Java SE specification maintenance version
  • 3d9e8d0: 8305681: Allow additional characters for GB18030-2022 (Level 2) support
  • 9740c24: 8301400: Allow additional characters for GB18030-2022 support

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 25, 2023
@openjdk openjdk bot closed this May 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 25, 2023
@openjdk
Copy link

openjdk bot commented May 25, 2023

@mrserb Pushed as commit 20b4c70.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants