Skip to content

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented May 2, 2023

Both tests were created for a bug introduced in the jdk9 and related to the "modules", so the patches are not applicable to the jdk8 but the test code coverage can be improved by the "new" tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307310: Backport the tests for JDK-8058969 and JDK-8039271 to the OpenJDK8

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/310/head:pull/310
$ git checkout pull/310

Update a local copy of the PR:
$ git checkout pull/310
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/310/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 310

View PR using the GUI difftool:
$ git pr show -t 310

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/310.diff

Webrev

Link to Webrev Comment

@mrserb mrserb changed the title 8307310: Backport the tests for JDK-8058969 and JDK-8039271 to the Op… 8307310: Backport the tests for JDK-8058969 and JDK-8039271 to the OpenJDK8 May 2, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mrserb mrserb marked this pull request as ready for review May 2, 2023 22:21
@openjdk openjdk bot added the rfr Pull request is ready for review label May 2, 2023
@mlbridge
Copy link

mlbridge bot commented May 2, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented May 10, 2023

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8307310: Backport the tests for JDK-8058969 and JDK-8039271 to the OpenJDK8

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 10, 2023
@mrserb
Copy link
Member Author

mrserb commented May 24, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 24, 2023

Going to push as commit 764dbd5.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 8562298: 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped
  • c7c080a: 8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4
  • 3e69b49: 8307531: [aarch64] JDK8 single-step debugging is extremely slow
  • 4328fec: 8303028: Update system property for Java SE specification maintenance version
  • 3d9e8d0: 8305681: Allow additional characters for GB18030-2022 (Level 2) support
  • 9740c24: 8301400: Allow additional characters for GB18030-2022 support

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 24, 2023
@openjdk openjdk bot closed this May 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 24, 2023
@openjdk
Copy link

openjdk bot commented May 24, 2023

@mrserb Pushed as commit 764dbd5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8307310 branch July 24, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants