Skip to content

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented May 2, 2023

Hi all,

This pull request contains a backport of commit 1c2754bf from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 3 Oct 2020 and was reviewed by Phil Race.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8253269: The CheckCommonColors test should provide more info on failure

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/311/head:pull/311
$ git checkout pull/311

Update a local copy of the PR:
$ git checkout pull/311
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/311/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 311

View PR using the GUI difftool:
$ git pr show -t 311

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/311.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1c2754bfe3294fb3c80defe5479bdd85b0d07e29 8253269: The CheckCommonColors test should provide more info on failure May 2, 2023
@openjdk
Copy link

openjdk bot commented May 2, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label May 2, 2023
@mrserb mrserb marked this pull request as ready for review May 2, 2023 22:34
@openjdk openjdk bot added the rfr Pull request is ready for review label May 2, 2023
@mlbridge
Copy link

mlbridge bot commented May 2, 2023

Webrevs

@mrserb
Copy link
Member Author

mrserb commented May 3, 2023

/clean

@openjdk openjdk bot added the clean Identical backport; no merge resolution required label May 3, 2023
@openjdk
Copy link

openjdk bot commented May 3, 2023

@mrserb This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented May 3, 2023

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8253269: The CheckCommonColors test should provide more info on failure

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 3, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented May 31, 2023

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member Author

mrserb commented May 31, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 31, 2023

Going to push as commit 1c802b2.
Since your change was applied there have been 13 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 31, 2023
@openjdk openjdk bot closed this May 31, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 31, 2023
@openjdk
Copy link

openjdk bot commented May 31, 2023

@mrserb Pushed as commit 1c802b2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant