Skip to content

8253269: The CheckCommonColors test should provide more info on failure #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

8253269: The CheckCommonColors test should provide more info on failure #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions jdk/test/java/awt/Robot/CheckCommonColors/CheckCommonColors.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand All @@ -22,11 +22,19 @@
*/

import java.awt.Color;
import java.awt.Dimension;
import java.awt.Frame;
import java.awt.Point;
import java.awt.Rectangle;
import java.awt.Robot;
import java.awt.Toolkit;
import java.awt.image.BufferedImage;
import java.io.File;
import java.io.IOException;
import java.util.List;

import javax.imageio.ImageIO;

/**
* @test
* @key headful
Expand Down Expand Up @@ -58,6 +66,7 @@ private static void test() {
Color.GREEN, Color.MAGENTA, Color.CYAN,
Color.BLUE}) {
frame.dispose();
robot.waitForIdle();
frame.setBackground(color);
frame.setVisible(true);
checkPixels(color);
Expand All @@ -68,14 +77,25 @@ private static void checkPixels(final Color color) {
int attempt = 0;
while (true) {
Point p = frame.getLocationOnScreen();
Color pixel = robot.getPixelColor(p.x + frame.getWidth() / 2,
p.y + frame.getHeight() / 2);
p.translate(frame.getWidth() / 2, frame.getHeight() / 2);
Color pixel = robot.getPixelColor(p.x, p.y);
if (color.equals(pixel)) {
return;
}
if (attempt > 10) {
frame.repaint();
if (attempt > 11) {
System.err.println("Expected: " + color);
System.err.println("Actual: " + pixel);
System.err.println("Point: " + p);
Dimension screenSize =
Toolkit.getDefaultToolkit().getScreenSize();
BufferedImage screen = robot.createScreenCapture(
new Rectangle(screenSize));
try {
File output = new File("ScreenCapture.png");
System.err.println("Dump screen to: " + output);
ImageIO.write(screen, "png", output);
} catch (IOException ex) {}
throw new RuntimeException("Too many attempts: " + attempt);
}
// skip Robot.waitForIdle to speedup the common case, but also take
Expand Down