Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307531: [aarch64] JDK8 single-step debugging is extremely slow #313

Closed
wants to merge 1 commit into from

Conversation

snazarkin
Copy link

@snazarkin snazarkin commented May 5, 2023

This fix removes a workaround from the early days of aarch64 port development. Not sure what the original reason was (@theRealAph could you please check?), now it literally blocks debugging on linux_aarch64.

On the test (attached to jira) single step takes about 30s, while the debugerless run completes in 3s. jdk11+ is free of this bug.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307531: [aarch64] JDK8 single-step debugging is extremely slow

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/313/head:pull/313
$ git checkout pull/313

Update a local copy of the PR:
$ git checkout pull/313
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/313/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 313

View PR using the GUI difftool:
$ git pr show -t 313

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/313.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 5, 2023

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 5, 2023
@mlbridge
Copy link

mlbridge bot commented May 5, 2023

Webrevs

Copy link
Contributor

@theRealAph theRealAph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I guess so.

I seem to remember that the _cur_stack_depth was often wrong, so much as to make it unusable, but I don't know what the current situation is.

@openjdk
Copy link

openjdk bot commented May 5, 2023

@snazarkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8307531: [aarch64] JDK8 single-step debugging is extremely slow

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 5, 2023
@snazarkin
Copy link
Author

Sure, I guess so.

I seem to remember that the _cur_stack_depth was often wrong, so much as to make it unusable, but I don't know what the current situation is.

I haven't found any problems with debugging the test, so I'd open a new ticket if anyone has the problem.

@snazarkin
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 8, 2023
@openjdk
Copy link

openjdk bot commented May 8, 2023

@snazarkin
Your change (at version 4dbfcdd) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Contributor

yan-too commented May 12, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented May 12, 2023

Going to push as commit 3e69b49.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 4328fec: 8303028: Update system property for Java SE specification maintenance version
  • 3d9e8d0: 8305681: Allow additional characters for GB18030-2022 (Level 2) support
  • 9740c24: 8301400: Allow additional characters for GB18030-2022 support

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 12, 2023
@openjdk openjdk bot closed this May 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 12, 2023
@openjdk
Copy link

openjdk bot commented May 12, 2023

@yan-too @snazarkin Pushed as commit 3e69b49.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants