-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8307531: [aarch64] JDK8 single-step debugging is extremely slow #313
Conversation
👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I guess so.
I seem to remember that the _cur_stack_depth was often wrong, so much as to make it unusable, but I don't know what the current situation is.
@snazarkin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
I haven't found any problems with debugging the test, so I'd open a new ticket if anyone has the problem. |
/integrate |
@snazarkin |
/sponsor |
Going to push as commit 3e69b49.
Your commit was automatically rebased without conflicts. |
@yan-too @snazarkin Pushed as commit 3e69b49. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This fix removes a workaround from the early days of aarch64 port development. Not sure what the original reason was (@theRealAph could you please check?), now it literally blocks debugging on linux_aarch64.
On the test (attached to jira) single step takes about 30s, while the debugerless run completes in 3s. jdk11+ is free of this bug.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/313/head:pull/313
$ git checkout pull/313
Update a local copy of the PR:
$ git checkout pull/313
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/313/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 313
View PR using the GUI difftool:
$ git pr show -t 313
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/313.diff
Webrev
Link to Webrev Comment