-
Notifications
You must be signed in to change notification settings - Fork 171
8301400: Allow additional characters for GB18030-2022 support #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewed-by: lance.andersen Backport-of: a039f39ee8486e990a4b4341c9e07fc49d3dac2d
|
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
This backport pull request has now been updated with issue from the original commit. |
|
@naotoj This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
@naotoj Please enable testing on your fork. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Oh I did not know that. Started the pre-submit tests: https://github.com/naotoj/jdk8u-dev/actions/runs/4929876090 |
Seems like you have accidentally tested current master branch commit, instead of branch from which this PR was made |
Resubmitted with the correct branch (includes both #314 and #315 changes): https://github.com/naotoj/jdk8u-dev/actions/runs/4931190096 |
|
/contributor add jlu |
|
@naotoj |
|
/integrate |
|
Going to push as commit 9740c24. |
This is a backport of GB18030 Level 1 part of the JSR337 MR5 (https://jcp.org/aboutJava/communityprocess/mrel/jsr337/index5.html) Reference Implementation
Progress
Issue
Reviewers
Contributors
<jlu@openjdk.org>Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/314/head:pull/314$ git checkout pull/314Update a local copy of the PR:
$ git checkout pull/314$ git pull https://git.openjdk.org/jdk8u-dev.git pull/314/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 314View PR using the GUI difftool:
$ git pr show -t 314Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/314.diff
Webrev
Link to Webrev Comment