Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301400: Allow additional characters for GB18030-2022 support #314

Closed
wants to merge 1 commit into from

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented May 8, 2023

This is a backport of GB18030 Level 1 part of the JSR337 MR5 (https://jcp.org/aboutJava/communityprocess/mrel/jsr337/index5.html) Reference Implementation


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8301400: Allow additional characters for GB18030-2022 support

Reviewers

Contributors

  • Justin Lu <jlu@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/314/head:pull/314
$ git checkout pull/314

Update a local copy of the PR:
$ git checkout pull/314
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/314/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 314

View PR using the GUI difftool:
$ git pr show -t 314

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/314.diff

Webrev

Link to Webrev Comment

Reviewed-by: lance.andersen
Backport-of: a039f39ee8486e990a4b4341c9e07fc49d3dac2d
@bridgekeeper
Copy link

bridgekeeper bot commented May 8, 2023

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@naotoj naotoj changed the title 8301400: Allow additional characters for GB18030-2022 support Backport b08cddec8625424b1292051088513a60606ef1e9 May 8, 2023
@openjdk openjdk bot changed the title Backport b08cddec8625424b1292051088513a60606ef1e9 8305681: Allow additional characters for GB18030-2022 (Level 2) support May 8, 2023
@openjdk
Copy link

openjdk bot commented May 8, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label May 8, 2023
@naotoj naotoj changed the title 8305681: Allow additional characters for GB18030-2022 (Level 2) support Backport a039f39ee8486e990a4b4341c9e07fc49d3dac2d May 8, 2023
@openjdk openjdk bot changed the title Backport a039f39ee8486e990a4b4341c9e07fc49d3dac2d 8301400: Allow additional characters for GB18030-2022 support May 8, 2023
@openjdk
Copy link

openjdk bot commented May 8, 2023

This backport pull request has now been updated with issue from the original commit.

@naotoj naotoj marked this pull request as ready for review May 9, 2023 18:46
@openjdk openjdk bot added the rfr Pull request is ready for review label May 9, 2023
@mlbridge
Copy link

mlbridge bot commented May 9, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented May 9, 2023

@naotoj This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8301400: Allow additional characters for GB18030-2022 support

Co-authored-by: Justin Lu <jlu@openjdk.org>
Reviewed-by: lancea, iris, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 9, 2023
@jerboaa
Copy link
Contributor

jerboaa commented May 9, 2023

@naotoj Please enable testing on your fork. Thanks!

Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label May 9, 2023
@naotoj
Copy link
Member Author

naotoj commented May 9, 2023

@naotoj Please enable testing on your fork. Thanks!

Oh I did not know that. Started the pre-submit tests: https://github.com/naotoj/jdk8u-dev/actions/runs/4929876090

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 9, 2023
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels May 9, 2023
@zzambers
Copy link
Contributor

zzambers commented May 9, 2023

@naotoj Please enable testing on your fork. Thanks!

Oh I did not know that. Started the pre-submit tests: https://github.com/naotoj/jdk8u-dev/actions/runs/4929876090

Seems like you have accidentally tested current master branch commit, instead of branch from which this PR was made

@naotoj
Copy link
Member Author

naotoj commented May 9, 2023

Seems like you have accidentally tested current master branch commit, instead of branch from which this PR was made

Resubmitted with the correct branch (includes both #314 and #315 changes): https://github.com/naotoj/jdk8u-dev/actions/runs/4931190096

@naotoj
Copy link
Member Author

naotoj commented May 10, 2023

/contributor add jlu

@openjdk
Copy link

openjdk bot commented May 10, 2023

@naotoj
Contributor Justin Lu <jlu@openjdk.org> successfully added.

@naotoj
Copy link
Member Author

naotoj commented May 10, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 10, 2023

Going to push as commit 9740c24.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 10, 2023
@openjdk openjdk bot closed this May 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 10, 2023
@openjdk
Copy link

openjdk bot commented May 10, 2023

@naotoj Pushed as commit 9740c24.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
6 participants