-
Notifications
You must be signed in to change notification settings - Fork 171
8305681: Allow additional characters for GB18030-2022 (Level 2) support #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewed-by: lance.andersen Backport-of: a039f39ee8486e990a4b4341c9e07fc49d3dac2d
Reviewed-by: lance.andersen Backport-of: b08cddec8625424b1292051088513a60606ef1e9
|
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
/contributor add jlu |
|
@naotoj |
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8305681
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
@naotoj This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 3d9e8d0. |
This is a backport of GB18030 Level 2 part of the JSR337 MR5 (https://jcp.org/aboutJava/communityprocess/mrel/jsr337/index5.html) Reference Implementation
Progress
Issue
Reviewers
Contributors
<jlu@openjdk.org>Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/315/head:pull/315$ git checkout pull/315Update a local copy of the PR:
$ git checkout pull/315$ git pull https://git.openjdk.org/jdk8u-dev.git pull/315/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 315View PR using the GUI difftool:
$ git pr show -t 315Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/315.diff
Webrev
Link to Webrev Comment