Skip to content

Conversation

@naotoj
Copy link
Member

@naotoj naotoj commented May 9, 2023

This is a backport of GB18030 Level 2 part of the JSR337 MR5 (https://jcp.org/aboutJava/communityprocess/mrel/jsr337/index5.html) Reference Implementation


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305681: Allow additional characters for GB18030-2022 (Level 2) support

Reviewers

Contributors

  • Justin Lu <jlu@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/315/head:pull/315
$ git checkout pull/315

Update a local copy of the PR:
$ git checkout pull/315
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/315/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 315

View PR using the GUI difftool:
$ git pr show -t 315

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/315.diff

Webrev

Link to Webrev Comment

naotoj added 2 commits May 8, 2023 20:19
Reviewed-by: lance.andersen
Backport-of: a039f39ee8486e990a4b4341c9e07fc49d3dac2d
Reviewed-by: lance.andersen
Backport-of: b08cddec8625424b1292051088513a60606ef1e9
@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2023

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into pr/314 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b08cddec8625424b1292051088513a60606ef1e9 8305681: Allow additional characters for GB18030-2022 (Level 2) support May 9, 2023
@openjdk
Copy link

openjdk bot commented May 9, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label May 9, 2023
@naotoj naotoj marked this pull request as ready for review May 9, 2023 18:59
@openjdk openjdk bot added the rfr Pull request is ready for review label May 9, 2023
@mlbridge
Copy link

mlbridge bot commented May 9, 2023

Webrevs

@naotoj
Copy link
Member Author

naotoj commented May 10, 2023

/contributor add jlu

@openjdk
Copy link

openjdk bot commented May 10, 2023

@naotoj
Contributor Justin Lu <jlu@openjdk.org> successfully added.

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/314 to master May 10, 2023 17:05
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8305681
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented May 10, 2023

@naotoj This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8305681: Allow additional characters for GB18030-2022 (Level 2) support

Co-authored-by: Justin Lu <jlu@openjdk.org>
Reviewed-by: lancea, iris, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 10, 2023
@naotoj
Copy link
Member Author

naotoj commented May 10, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 10, 2023

Going to push as commit 3d9e8d0.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 10, 2023
@openjdk openjdk bot closed this May 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 10, 2023
@openjdk
Copy link

openjdk bot commented May 10, 2023

@naotoj Pushed as commit 3d9e8d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants