Skip to content

Conversation

@justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented May 9, 2023

Please review this change which is a backport of the java.specification.maintenance.version system property part of the JSR337 MR5 Reference Implementation.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303028: Update system property for Java SE specification maintenance version

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/316/head:pull/316
$ git checkout pull/316

Update a local copy of the PR:
$ git checkout pull/316
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/316/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 316

View PR using the GUI difftool:
$ git pr show -t 316

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/316.diff

Webrev

Link to Webrev Comment

… version

Reviewed-by: lancea, iris, naoto, andrew
@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2023

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e5ac7a1b7e8df1e56a7e78bba6a2b9ed7fc297f1 8285497: Add system property for Java SE specification maintenance version May 9, 2023
@openjdk
Copy link

openjdk bot commented May 9, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label May 9, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label May 9, 2023
@openjdk
Copy link

openjdk bot commented May 9, 2023

@justin-curtis-lu This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8303028: Update system property for Java SE specification maintenance version

Reviewed-by: rriggs, lancea, naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RogerRiggs, @LanceAndersen, @naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels May 9, 2023
@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 9, 2023
@mlbridge
Copy link

mlbridge bot commented May 9, 2023

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels May 9, 2023
@justin-curtis-lu justin-curtis-lu changed the title 8285497: Add system property for Java SE specification maintenance version Backport 9eb797dc6ac09f250b4e308abd43bffa6529c534 May 9, 2023
@openjdk openjdk bot changed the title Backport 9eb797dc6ac09f250b4e308abd43bffa6529c534 8303028: Update system property for Java SE specification maintenance version May 9, 2023
@openjdk
Copy link

openjdk bot commented May 9, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the clean Identical backport; no merge resolution required label May 9, 2023
@jerboaa
Copy link
Contributor

jerboaa commented May 10, 2023

@justin-curtis-lu Please enable pre-submit testing on your fork. Thanks!

@justin-curtis-lu
Copy link
Member Author

Thanks for letting me know @jerboaa. I have enabled pre-submit testing and triggered a run: https://github.com/justin-curtis-lu/jdk8u-dev/actions/runs/4939311317

@jerboaa
Copy link
Contributor

jerboaa commented May 11, 2023

This one is fine to integrate. The bug is approved too.

@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 11, 2023
@openjdk
Copy link

openjdk bot commented May 11, 2023

@justin-curtis-lu
Your change (at version ebfd3da) is now ready to be sponsored by a Committer.

@openjdk openjdk bot removed ready Pull request is ready to be integrated sponsor Pull request is ready to be sponsored labels May 11, 2023
@naotoj
Copy link
Member

naotoj commented May 11, 2023

/sponsor

@openjdk openjdk bot added sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels May 11, 2023
@openjdk
Copy link

openjdk bot commented May 11, 2023

Going to push as commit 4328fec.
Since your change was applied there have been 64 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 11, 2023
@openjdk openjdk bot closed this May 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 11, 2023
@openjdk
Copy link

openjdk bot commented May 11, 2023

@naotoj @justin-curtis-lu Pushed as commit 4328fec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

6 participants