-
Notifications
You must be signed in to change notification settings - Fork 171
8303028: Update system property for Java SE specification maintenance version #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… version Reviewed-by: lancea, iris, naoto, andrew
|
👋 Welcome back jlu! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@justin-curtis-lu This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 64 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RogerRiggs, @LanceAndersen, @naotoj) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
@justin-curtis-lu Please enable pre-submit testing on your fork. Thanks! |
|
Thanks for letting me know @jerboaa. I have enabled pre-submit testing and triggered a run: https://github.com/justin-curtis-lu/jdk8u-dev/actions/runs/4939311317 |
|
This one is fine to integrate. The bug is approved too. |
|
/integrate |
|
@justin-curtis-lu |
|
/sponsor |
|
Going to push as commit 4328fec.
Your commit was automatically rebased without conflicts. |
|
@naotoj @justin-curtis-lu Pushed as commit 4328fec. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this change which is a backport of the
java.specification.maintenance.versionsystem property part of the JSR337 MR5 Reference Implementation.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/316/head:pull/316$ git checkout pull/316Update a local copy of the PR:
$ git checkout pull/316$ git pull https://git.openjdk.org/jdk8u-dev.git pull/316/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 316View PR using the GUI difftool:
$ git pr show -t 316Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/316.diff
Webrev
Link to Webrev Comment