8307837: [8u] Check step in GHA should also print errors

[zzambers]

Check step currently only prints list of failed tests. It should also print tests, which finished with error (e.g. test ending on timeout). See e.g.: https://github.com/naotoj/jdk8u-dev/actions/runs/4931190096/jobs/8813500528

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8307837 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8307837: [8u] Check step in GHA should also print errors (Enhancement - P4 - Approved)

Reviewers

• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/317/head:pull/317
$ git checkout pull/317

Update a local copy of the PR:
$ git checkout pull/317
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/317/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 317

View PR using the GUI difftool:
$ git pr show -t 317

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/317.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (9b6786b1)

[bridgekeeper]

@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@zzambers This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[zzambers]

/open

[openjdk]

@zzambers This pull request is now open

[bridgekeeper]

@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@zzambers This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[zzambers]

/open

[openjdk]

@zzambers This pull request is now open

[gnu-andrew]

Changes look fine, though the referenced link has expired.

Any way we can test this works as expected?

[zzambers]

@gnu-andrew I have made branch with dummy failing and erroring test added on top of this. Works as expected, see: https://github.com/zzambers/jdk8u-dev/actions/runs/6234555212/job/16923516100

[gnu-andrew]

Thanks. Looks good to me.
Please label the bug with jdk8u-fix-request and add an appropriate comment to request approval.

[openjdk]

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8307837: [8u] Check step in GHA should also print errors

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

• f4260a4: 8305815: Update Libpng to 1.6.39
• 961ab46: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int)
• a9e2be4: Merge
• 05254ef: Merge
• e74d29d: 8295894: Remove SECOM certificate that is expiring in September 2023
• 0ee1400: Merge
• 599bb77: 8225687: Newly added sspi.cpp in JDK-6722928 still contains some small errors
• ee4caa8: 8029995: accept yes/no for boolean krb5.conf settings
• 5b76d03: 8295685: Update Libpng to 1.6.38
• 50069a8: 8209115: adjust libsplashscreen linux ppc64le builds for easier libpng update
• ... and 50 more: https://git.openjdk.org/jdk8u-dev/compare/3147b1bafe12326a97269655de46f066931f3ee4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[gnu-andrew]

Approved.

[openjdk]

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[zzambers]

@gnu-andrew thanks
/integrate

[openjdk]

Going to push as commit 27058b2.
Since your change was applied there have been 60 commits pushed to the master branch:

• f4260a4: 8305815: Update Libpng to 1.6.39
• 961ab46: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int)
• a9e2be4: Merge
• 05254ef: Merge
• e74d29d: 8295894: Remove SECOM certificate that is expiring in September 2023
• 0ee1400: Merge
• 599bb77: 8225687: Newly added sspi.cpp in JDK-6722928 still contains some small errors
• ee4caa8: 8029995: accept yes/no for boolean krb5.conf settings
• 5b76d03: 8295685: Update Libpng to 1.6.38
• 50069a8: 8209115: adjust libsplashscreen linux ppc64le builds for easier libpng update
• ... and 50 more: https://git.openjdk.org/jdk8u-dev/compare/3147b1bafe12326a97269655de46f066931f3ee4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@zzambers Pushed as commit 27058b2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.