Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8305975: Add TWCA Global Root CA #319

Closed

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented May 24, 2023

Clean backport from JDK 11u modulo path changes.

Testing:

  • sun/security/lib/cacerts/VerifyCACerts.java and security/infra/java/security/cert/CertPathValidator/certification passed.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/319/head:pull/319
$ git checkout pull/319

Update a local copy of the PR:
$ git checkout pull/319
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/319/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 319

View PR using the GUI difftool:
$ git pr show -t 319

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/319.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 24, 2023

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 093f02aadbeedb8f22db7512cb5555c4c890b0fc 8305975: Add TWCA Global Root CA May 24, 2023
@openjdk
Copy link

openjdk bot commented May 24, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 24, 2023
@jerboaa
Copy link
Contributor Author

jerboaa commented May 24, 2023

Marking as clean as the only change is the path to files.

/clean

@openjdk openjdk bot added the clean label May 24, 2023
@openjdk
Copy link

openjdk bot commented May 24, 2023

@jerboaa This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented May 24, 2023

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8305975: Add TWCA Global Root CA

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 20b4c70: 8072678: Wrong exception messages in java.awt.color.ICC_ColorSpace
  • 764dbd5: 8307310: Backport the tests for JDK-8058969 and JDK-8039271 to the OpenJDK8
  • 8562298: 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped
  • c7c080a: 8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 24, 2023
@mlbridge
Copy link

mlbridge bot commented May 24, 2023

Webrevs

@openjdk openjdk bot mentioned this pull request May 25, 2023
3 tasks
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed clean and looks good to me. Approved for 8u.

@jerboaa
Copy link
Contributor Author

jerboaa commented May 25, 2023

Thanks!

/integrate

@openjdk
Copy link

openjdk bot commented May 25, 2023

Going to push as commit 54208fc.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 20b4c70: 8072678: Wrong exception messages in java.awt.color.ICC_ColorSpace
  • 764dbd5: 8307310: Backport the tests for JDK-8058969 and JDK-8039271 to the OpenJDK8
  • 8562298: 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped
  • c7c080a: 8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 25, 2023
@openjdk openjdk bot closed this May 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 25, 2023
@openjdk
Copy link

openjdk bot commented May 25, 2023

@jerboaa Pushed as commit 54208fc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants