-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8304760: Add 2 Microsoft TLS roots #320
Conversation
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
This is a clean backport as the only changes have been path adjustments to match the 8u layout. /clean |
@jerboaa This backport pull request is now marked as clean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed clean and looks good to me. Approved for 8u.
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout jdk-8304760-add-ms-cacerts
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@jerboaa This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
c8173f6
to
ccf66ea
Compare
@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
The one x64 test failure seems unrelated to this PR. |
/integrate |
Going to push as commit f5c2c39. |
Clean backport modulo path changes to adjust to the OpenJDK 8u layout. I'd like to get this into 8u382 for symmetry with Oracle JDK 8u381.
Testing:
sun/security/lib/cacerts/VerifyCACerts.java
andsecurity/infra/java/security/cert/CertPathValidator/certification
passed.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/320/head:pull/320
$ git checkout pull/320
Update a local copy of the PR:
$ git checkout pull/320
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/320/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 320
View PR using the GUI difftool:
$ git pr show -t 320
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/320.diff
Webrev
Link to Webrev Comment