Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309143: [8u] fix archiving inconsistencies in GHA #327

Closed
wants to merge 1 commit into from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented May 30, 2023

There are few inconsistencies when it comes to packing/unpacking of JDK in GHA. Tar archives are not gzipped despite use .tar.gz extension. Zip JDK archives on windows are being extracted by tar. These inconsistencies do not cause failures, but better to fix them. Affects JDK 8 only.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309143: [8u] fix archiving inconsistencies in GHA (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/327/head:pull/327
$ git checkout pull/327

Update a local copy of the PR:
$ git checkout pull/327
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/327/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 327

View PR using the GUI difftool:
$ git pr show -t 327

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/327.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 30, 2023

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 30, 2023
@mlbridge
Copy link

mlbridge bot commented May 30, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Jun 22, 2023

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8309143: [8u] fix archiving inconsistencies in GHA

Reviewed-by: phh, sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 22, 2023
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@zzambers
Copy link
Contributor Author

zzambers commented Jul 10, 2023

@jerboaa @phohensee thanks
/integrate

@openjdk
Copy link

openjdk bot commented Jul 10, 2023

Going to push as commit 108003e.
Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 10, 2023
@openjdk openjdk bot closed this Jul 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 10, 2023
@openjdk
Copy link

openjdk bot commented Jul 10, 2023

@zzambers Pushed as commit 108003e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants