Skip to content

Conversation

@apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented Jun 1, 2023

Hi!

Here is backport of forgotten tests for JDK-8179503: Java should support GET OCSP calls.

Original GetAndPostTests.java backported from 11u with the following changes

  • unsupported List.of(), Set.of(), Map.of() replaced with equivalents
  • algorithm parameter dropped from instantiation PKCS8EncodedKeySpec
  • required public static enum SSLSocketTemplate.Cert copied from 11u

Verification (amd64/20.04LTS): newly added jdk/test/java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java
Regression (amd64/20.04LTS): jdk_security


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309274: [TEST] the tests for JDK-8179503 (GET OCSP calls support) were not backported

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/328/head:pull/328
$ git checkout pull/328

Update a local copy of the PR:
$ git checkout pull/328
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/328/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 328

View PR using the GUI difftool:
$ git pr show -t 328

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/328.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 1, 2023

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 1, 2023
@apavlyutkin apavlyutkin changed the title 8309274: backporting tests for GET and POST OCSP calls JDK-8309274: [TEST] the tests for JDK-8179503 (GET OCSP calls support) were not backported Jun 1, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 1, 2023

Webrevs

@apavlyutkin apavlyutkin closed this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant