-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8221988: add possibility to build with Visual Studio 2019 #33
Conversation
Reviewed-by: mdoerr Backport-of: 2a00db0b2eb2f491c7b0b8500b855d8d933114cf
👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
Hi @apavlyutkin, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With which versions of Visual Studio has this been tested?
Hey all - missed this whilst travelling. Happy to help test this internally at MSFT |
Ping. Can we proceed somehow? There are several more backports required to enable MSVC 2019 support, but they all depend on this one. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, though, I have no way to test this myself.
@apavlyutkin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 35 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa, @gnu-andrew) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
JDK-8221988 labelled with jdk8u-fix-request |
GHA is testing VS2010 & VS2017, for what it's worth. Currently wondering what broke MacOS (not specific to this fix) |
Extra testing is always welcome :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport looks good to me and GHA suggests it doesn't break existing builds on VS2010 & VS2017.
There is documentation in 8u but it is in README-builds.html
and currently only seems to mention VS2010. We should probably do an update of the documentation, starting with a JDK-8176509 backport so it reflects the current status quo, especially after the move to Git. It's fine to leave this change out here though.
Approved. |
/integrate |
@apavlyutkin |
/sponsor |
Going to push as commit 51f69d9.
Your commit was automatically rebased without conflicts. |
@yan-too @apavlyutkin Pushed as commit 51f69d9. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Seemed OK with our internal testing FWIW - sorry to be late to the party
here!
Cheers,
Martijn
…On Thu, 12 May 2022 at 06:28, openjdk[bot] ***@***.***> wrote:
@yan-too <https://github.com/yan-too> @apavlyutkin
<https://github.com/apavlyutkin> Pushed as commit 51f69d9
<51f69d9>
.
💡 You may see a message that your pull request was closed with unmerged
commits. This can be safely ignored.
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABME2AJONMPQ3Z656Y3AOTVJSJGRANCNFSM5S2KGB4Q>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Hi!
Please review backport of 8221988. This one opens a bunch of backports enabling support of VS2019. WARNING: the patch DOES NOT enable the building with MSVS2019 toolkit, that requires 5-6 more backports. The patch ONLY adds recognition of MSVS2019 to the build system.
The 11u patch applied with the following changes:
Verification:
bash configure
under VS2019 prompt.Regression:
@RealCLanger @MDoerr if you take a look at this I will be very grateful
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/33/head:pull/33
$ git checkout pull/33
Update a local copy of the PR:
$ git checkout pull/33
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/33/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 33
View PR using the GUI difftool:
$ git pr show -t 33
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/33.diff