Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8221988: add possibility to build with Visual Studio 2019 #33

Closed
wants to merge 4 commits into from
Closed

8221988: add possibility to build with Visual Studio 2019 #33

wants to merge 4 commits into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented Apr 7, 2022

Hi!

Please review backport of 8221988. This one opens a bunch of backports enabling support of VS2019. WARNING: the patch DOES NOT enable the building with MSVS2019 toolkit, that requires 5-6 more backports. The patch ONLY adds recognition of MSVS2019 to the build system.

The 11u patch applied with the following changes:

  • changes to absent documentation files skipped
  • resolved baseline conflicts toolchain_windows.m4
  • valid MSVS versions were ascending sorted

Verification: bash configure under VS2019 prompt.

Regression:

  • VS2017 full build (both 64/32-bit): ok
  • VS2015 full build: ok (requires --with-extra-cflags='/EHsc /wd4091' --with-extra-cxxflags='/EHsc /wd4091')
  • VS2013 full build: ok
  • VS2012 full build: ok
  • VS2010 full build: ok

@RealCLanger @MDoerr if you take a look at this I will be very grateful


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8221988: add possibility to build with Visual Studio 2019

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/33/head:pull/33
$ git checkout pull/33

Update a local copy of the PR:
$ git checkout pull/33
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/33/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 33

View PR using the GUI difftool:
$ git pr show -t 33

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/33.diff

Alexey Pavlyutkin added 2 commits April 7, 2022 21:40
Reviewed-by: mdoerr
Backport-of: 2a00db0b2eb2f491c7b0b8500b855d8d933114cf
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 7, 2022

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f2240cc5b1f6e82c3d36551f36cd22916c1772bd 8221988: add possibility to build with Visual Studio 2019 Apr 7, 2022
@openjdk
Copy link

openjdk bot commented Apr 7, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 7, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 7, 2022

Webrevs

@RealCLanger
Copy link
Contributor

Hi @apavlyutkin,
apart from my other comment I think the backport looks okay. However, I've no means to test it. Probably somebody more involved with OpenJDK 8 (and its Windows build) should have a look...

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With which versions of Visual Studio has this been tested?

common/autoconf/toolchain_windows.m4 Outdated Show resolved Hide resolved
@karianna
Copy link
Contributor

Hey all - missed this whilst travelling. Happy to help test this internally at MSFT

@apavlyutkin
Copy link
Contributor Author

Ping. Can we proceed somehow? There are several more backports required to enable MSVC 2019 support, but they all depend on this one. Thank you

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, though, I have no way to test this myself.

@openjdk
Copy link

openjdk bot commented May 11, 2022

@apavlyutkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8221988: add possibility to build with Visual Studio 2019

Reviewed-by: sgehwolf, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 11, 2022
@apavlyutkin
Copy link
Contributor Author

JDK-8221988 labelled with jdk8u-fix-request

@gnu-andrew
Copy link
Member

With which versions of Visual Studio has this been tested?

GHA is testing VS2010 & VS2017, for what it's worth. Currently wondering what broke MacOS (not specific to this fix)

@gnu-andrew
Copy link
Member

Hey all - missed this whilst travelling. Happy to help test this internally at MSFT

Extra testing is always welcome :)

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good to me and GHA suggests it doesn't break existing builds on VS2010 & VS2017.

There is documentation in 8u but it is in README-builds.html and currently only seems to mention VS2010. We should probably do an update of the documentation, starting with a JDK-8176509 backport so it reflects the current status quo, especially after the move to Git. It's fine to leave this change out here though.

@gnu-andrew
Copy link
Member

JDK-8221988 labelled with jdk8u-fix-request

Approved.

@apavlyutkin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 11, 2022
@openjdk
Copy link

openjdk bot commented May 11, 2022

@apavlyutkin
Your change (at version 36e603c) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Contributor

yan-too commented May 12, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented May 12, 2022

Going to push as commit 51f69d9.
Since your change was applied there have been 35 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 12, 2022
@openjdk openjdk bot closed this May 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 12, 2022
@openjdk
Copy link

openjdk bot commented May 12, 2022

@yan-too @apavlyutkin Pushed as commit 51f69d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@karianna
Copy link
Contributor

karianna commented May 12, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

6 participants